Re: org-babel-gnuplot-quote-tsv-field does not work properly (quotes); org-plot-quote-tsv-field does though

[Miguel Ruiz <rbenit68@yahoo.es>]

[-- Attachment #1.1: Type: text/plain, Size: 720 bytes --]

Thank you, Bastien. I'd prefer some of you writes the changelog entry; the patch is attached.





El Domingo 5 de enero de 2014 12:51, Bastien <bzg@gnu.org> escribió:
 
Hi Miguel,

Miguel Ruiz <rbenit68@yahoo.es> writes:

> Is it *this* enough:
>
> diff --git a/lisp/ob-gnuplot.el b/lisp/ob-gnuplot.el
> index cc9186b..426077b 100644
> --- a/lisp/ob-gnuplot.el
> +++ b/lisp/ob-gnuplot.el

Thanks for the fix -- could you format it with git format-patch
and add a proper ChangeLog?

See http://orgmode.org/worg/org-contribute.html#sec-4-2 for
details on how to submit a patch.  Please add TINYCHANGE at
the end of your commit message if you didn't sign the FSF
papers.

Thanks!

-- 
Bastien

[-- Attachment #1.2: Type: text/html, Size: 1940 bytes --]

[-- Attachment #2: 0001-Fix-typo-that-stopped-necessary-quoted-strings-in-gn.patch --]
[-- Type: application/octet-stream, Size: 847 bytes --]

From 1d00a79dbc473e35abc60aeaca8e0cfa7b59fdf0 Mon Sep 17 00:00:00 2001
From: "U-usuario-PC\\usuario" <rbenit68@yahoo.es>
Date: Sun, 5 Jan 2014 13:18:16 +0100
Subject: [PATCH] Fix typo that stopped necessary quoted strings in gnuplot
 temp data file from tables

---
 lisp/ob-gnuplot.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lisp/ob-gnuplot.el b/lisp/ob-gnuplot.el
index cc9186b..426077b 100644
--- a/lisp/ob-gnuplot.el
+++ b/lisp/ob-gnuplot.el
@@ -253,7 +253,7 @@ then create one.  Return the initialized session.  The current
 	(org-babel-gnuplot-quote-timestamp-field s)
       (if (zerop (length s))
 	  (or *org-babel-gnuplot-missing* s)
-	(if (string-match "[ \"]" "?")
+	(if (string-match "[ \"]" s)
 	    (concat "\"" (mapconcat 'identity (split-string s "\"") "\"\"")
 		    "\"")
 	  s)))))
-- 
1.7.9