Bug: LOGGING property does not stop asking for a note

Bug: LOGGING property does not stop asking for a note

[Bernt Hansen]

Hi Carsten,

I've been trying to get org-mode to stop prompting for a note for some
of my repeated tasks when they are marked as DONE and rescheduled.

Either I'm doing something wrong or this is a bug.

,----[ minimal.emacs ]
| (setq org-log-done '(state))
| (setq inhibit-splash-screen t)
| (global-font-lock-mode t)
| (add-to-list 'load-path (expand-file-name "~/git/org-mode"))
| (add-to-list 'auto-mode-alist '("\\.org$" . org-mode))
| (require 'org-install)
| (define-key global-map "\C-ca" 'org-agenda)
| (custom-set-variables
|  '(org-agenda-files (quote ("~/org/test.org"))))
| (org-agenda-list)
`----

,----[ test.org ]
| * TODO one
|   SCHEDULED: <2008-02-14 Thu>
|   - State "TODO"       [2008-02-14 Thu 13:46]
|   - State "DONE"       [2008-02-14 Thu 13:45]
| * TODO two
|   SCHEDULED: <2008-02-28 Thu +1w>
|   - State "DONE"       [2008-02-14 Thu 13:46]
|   - State "DONE"       [2008-02-14 Thu 13:45]
|   :PROPERTIES:
|   :LOGGING: off
|   :END:  
| * TODO three
|   SCHEDULED: <2008-02-14 Thu>
|   - State "TODO"       [2008-02-14 Thu 13:46]
|   - State "DONE"       [2008-02-14 Thu 13:45]
|   :PROPERTIES:
|   :LOGGING: off
|   :END:
| *** TODO One Two Three
|     
`----

I have org-log-done set to state globally and I want to override this
for the repeated task (two) and for another normal task (three).

It always prompts for a note when I change the state of the TODO item on
any of these tasks.

Am I missing something?

I'm running from the git development tree - currently on commit
45f1d176da18453bf2fa7f099c486f98351bcab4

Org-mode version 5.21
GNU Emacs 22.1.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2007-11-03 on pacem, modified by Debian

Regards,
Bernt

Re: Bug: LOGGING property does not stop asking for a note

[Carsten Dominik]

Hi Bernt,

On Feb 14, 2008, at 7:53 PM, Bernt Hansen wrote:

> Hi Carsten,
>
> I've been trying to get org-mode to stop prompting for a note for some
> of my repeated tasks when they are marked as DONE and rescheduled.
>
> Either I'm doing something wrong or this is a bug.
>
> ,----[ minimal.emacs ]
> | (setq org-log-done '(state))
> | (setq inhibit-splash-screen t)
> | (global-font-lock-mode t)
> | (add-to-list 'load-path (expand-file-name "~/git/org-mode"))
> | (add-to-list 'auto-mode-alist '("\\.org$" . org-mode))
> | (require 'org-install)
> | (define-key global-map "\C-ca" 'org-agenda)
> | (custom-set-variables
> |  '(org-agenda-files (quote ("~/org/test.org"))))
> | (org-agenda-list)
> `----
>
> ,----[ test.org ]
> | * TODO one
> |   SCHEDULED: <2008-02-14 Thu>
> |   - State "TODO"       [2008-02-14 Thu 13:46]
> |   - State "DONE"       [2008-02-14 Thu 13:45]
> | * TODO two
> |   SCHEDULED: <2008-02-28 Thu +1w>
> |   - State "DONE"       [2008-02-14 Thu 13:46]
> |   - State "DONE"       [2008-02-14 Thu 13:45]
> |   :PROPERTIES:
> |   :LOGGING: off
> |   :END:
> | * TODO three
> |   SCHEDULED: <2008-02-14 Thu>
> |   - State "TODO"       [2008-02-14 Thu 13:46]
> |   - State "DONE"       [2008-02-14 Thu 13:45]
> |   :PROPERTIES:
> |   :LOGGING: off
> |   :END:
> | *** TODO One Two Three
> |
> `----
>
> I have org-log-done set to state globally and I want to override this
> for the repeated task (two) and for another normal task (three).
>
> It always prompts for a note when I change the state of the TODO  
> item on
> any of these tasks.
>
> Am I missing something?


First of all, you would need

   :LOGGING: nologging

this must be one of the standard keywords, it is parsed exactly like  
an in-buffer option.

Secondly, I am internally forcing a log entry when repeating an entry,
with the assumption that you'd always want a log of acting on a  
repeating
task.

Hmmm, maybe a LOGGING property should be honoured also in this case....

- Carsten

Re: Bug: LOGGING property does not stop asking for a note

[Bernt Hansen]

Carsten Dominik <dominik@science.uva.nl> writes:

> First of all, you would need
>
>   :LOGGING: nologging
>
> this must be one of the standard keywords, it is parsed exactly like
> an in-buffer option.

Thanks - using the right keyword makes it work much better :).

The values for the :LOGGING: property are not obvious to me - I went
through the org.pdf file and the source when I came up with 'off' :/
I was expecting it to work for repeated tasks and having it not work
probably made me try other values for LOGGING (I ended up reading the
org.el source to try to figure out what the right value was.)

Obviously I need to polish my Lisp skills some more... (do I have any
yet?  :) )

If I come up with a good patch for the LOGGING documentation I'll send
it in.

>
> Secondly, I am internally forcing a log entry when repeating an entry,
> with the assumption that you'd always want a log of acting on a
> repeating
> task.
>
> Hmmm, maybe a LOGGING property should be honoured also in this case....

Yes I'd like to be able to turn this off for some repeated tasks.  They
are there to remind me to do them but I don't need the extra overhead of
adding a log note each time they're done.

Things like my weekly reminder to pay the bills :) don't need log notes.
Yes -- I regularly do not know what day of the week it is ;)

Thanks!
Bernt

Re: Bug: LOGGING property does not stop asking for a note

[Carsten Dominik]

[-- Attachment #1.1: Type: text/plain, Size: 3717 bytes --]

Hi Bernt,

I have now fixed this, just pushed it into the git repo.

Here is the setup that you would need.  Please note:

(1) Starting from 5.22, in fact starting with the current git master,
     you should be using org-log-progress instead of org-log-done which
     is now obsolete and only an alias for org-log-progress.
(2) For the repeating entry you need to turn off with both
     nologging and nologrepeat.
(3) Use nologging here.

If you have the time, maybe you'd enjoy summarizing this again in a
message, and then linking to it from the Worg FAQ?

- Carsten

,----[ minimal.emacs ]
| (setq org-log-progress '(state))             ;(1)
| (setq inhibit-splash-screen t)
| (global-font-lock-mode t)
| (add-to-list 'load-path (expand-file-name "~/git/org-mode"))
| (add-to-list 'auto-mode-alist '("\\.org$" . org-mode))
| (require 'org-install)
| (define-key global-map "\C-ca" 'org-agenda)
| (custom-set-variables
|  '(org-agenda-files (quote ("~/org/test.org"))))
| (org-agenda-list)
`----

,----[ test.org ]
| * TODO one
|   SCHEDULED: <2008-02-14 Thu>
|   - State "TODO"       [2008-02-14 Thu 13:46]
|   - State "DONE"       [2008-02-14 Thu 13:45]
| * TODO two
|   SCHEDULED: <2008-02-28 Thu +1w>
|   - State "DONE"       [2008-02-14 Thu 13:46]
|   - State "DONE"       [2008-02-14 Thu 13:45]
|   :PROPERTIES:
|   :LOGGING: nologging nologrepeat             ;(2)
|   :END:
| * TODO three
|   SCHEDULED: <2008-02-14 Thu>
|   - State "TODO"       [2008-02-14 Thu 13:46]
|   - State "DONE"       [2008-02-14 Thu 13:45]
|   :PROPERTIES:
|   :LOGGING: nologging                         ;(3)
|   :END:
| *** TODO One Two Three
|
On Feb 14, 2008, at 7:53 PM, Bernt Hansen wrote:

> Hi Carsten,
>
> I've been trying to get org-mode to stop prompting for a note for some
> of my repeated tasks when they are marked as DONE and rescheduled.
>
> Either I'm doing something wrong or this is a bug.
>
> ,----[ minimal.emacs ]
> | (setq org-log-done '(state))
> | (setq inhibit-splash-screen t)
> | (global-font-lock-mode t)
> | (add-to-list 'load-path (expand-file-name "~/git/org-mode"))
> | (add-to-list 'auto-mode-alist '("\\.org$" . org-mode))
> | (require 'org-install)
> | (define-key global-map "\C-ca" 'org-agenda)
> | (custom-set-variables
> |  '(org-agenda-files (quote ("~/org/test.org"))))
> | (org-agenda-list)
> `----
>
> ,----[ test.org ]
> | * TODO one
> |   SCHEDULED: <2008-02-14 Thu>
> |   - State "TODO"       [2008-02-14 Thu 13:46]
> |   - State "DONE"       [2008-02-14 Thu 13:45]
> | * TODO two
> |   SCHEDULED: <2008-02-28 Thu +1w>
> |   - State "DONE"       [2008-02-14 Thu 13:46]
> |   - State "DONE"       [2008-02-14 Thu 13:45]
> |   :PROPERTIES:
> |   :LOGGING: off
> |   :END:
> | * TODO three
> |   SCHEDULED: <2008-02-14 Thu>
> |   - State "TODO"       [2008-02-14 Thu 13:46]
> |   - State "DONE"       [2008-02-14 Thu 13:45]
> |   :PROPERTIES:
> |   :LOGGING: off
> |   :END:
> | *** TODO One Two Three
> |
> `----
>
> I have org-log-done set to state globally and I want to override this
> for the repeated task (two) and for another normal task (three).
>
> It always prompts for a note when I change the state of the TODO  
> item on
> any of these tasks.
>
> Am I missing something?
>
> I'm running from the git development tree - currently on commit
> 45f1d176da18453bf2fa7f099c486f98351bcab4
>
> Org-mode version 5.21
> GNU Emacs 22.1.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars)  
> of 2007-11-03 on pacem, modified by Debian
>
> Regards,
> Bernt
>
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode


[-- Attachment #1.2: Type: text/html, Size: 5454 bytes --]

[-- Attachment #2: Type: text/plain, Size: 204 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Bug: LOGGING property does not stop asking for a note

[Bernt Hansen]

Carsten Dominik <dominik@science.uva.nl> writes:

> I have now fixed this, just pushed it into the git repo.
>
> Here is the setup that you would need.  Please note:
>
> (1) Starting from 5.22, in fact starting with the current git master,
>     you should be using org-log-progress instead of org-log-done which
>     is now obsolete and only an alias for org-log-progress.
> (2) For the repeating entry you need to turn off with both
>     nologging and nologrepeat.
> (3) Use nologging here.
>
> If you have the time, maybe you'd enjoy summarizing this again in a
> message, and then linking to it from the Worg FAQ?

Thanks!!  I'll add an org task to update the Worg FAQ after I get this
all straight in my head. :)

How do you set both nologging and nologrepeat in properties?  Like this?

    :PROPERTIES:
    :LOGGING:  nologging
    :LOGGING:  nologrepeat
    :END:

I've removed my org-log-done setting and changed my todo tag definitions
to

(setq org-todo-keywords
      '((sequence "TODO(t)" "NEXT(n)" "WAITING(w@)" "SOMEDAY(s!)" "|" "DONE(d!)" "CANCELLED(c@)")))

and completing the repeated task still adds an entry for

    - State "DONE"       [2008-02-15 Fri 09:49]

So I must still be doing something wrong...
I thought nologging was supposed to turn that off.

Org-mode version 5.21+
GNU Emacs 22.1.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2007-11-03 on pacem, modified by Debian

,----[ minimal.emacs ]
| (setq org-todo-keywords
|       '((sequence "TODO(t)" "NEXT(n)" "WAITING(w@)" "SOMEDAY(s!)" "|" "DONE(d!)" "CANCELLED(c@)")))
| (setq inhibit-splash-screen t)
| (global-font-lock-mode t)
| (add-to-list 'load-path (expand-file-name "~/git/org-mode"))
| (add-to-list 'auto-mode-alist '("\\.org$" . org-mode))
| (require 'org-install)
| (define-key global-map "\C-ca" 'org-agenda)
| (custom-set-variables
|  '(org-agenda-files (quote ("~/org/test.org"))))
| (org-agenda-list)
`----

,----[ test.org ]
| * TODO one
|   SCHEDULED: <2008-02-14 Thu> 
| * TODO two
|   SCHEDULED: <2008-03-27 Thu +1w> 
|   :PROPERTIES:
|   :LOGGING: nologging
|   :LOGGING: nologrepeat
|   :END:  
| * TODO three
|   SCHEDULED: <2008-02-14 Thu> 
|   :PROPERTIES:
|   :LOGGING: nologging
|   :END:
| *** TODO One Two Three
|     
`----

Then if I change each task to DONE I get this
(no prompts for a closing note -- yay!)

 ,----[ test.org ]
| * DONE one
|   SCHEDULED: <2008-02-14 Thu> CLOSED: [2008-02-15 Fri 09:58]
|   - State "DONE"       [2008-02-15 Fri 09:58]
| * TODO two
|   SCHEDULED: <2008-04-03 Thu +1w> 
|   - State "DONE"       [2008-02-15 Fri 09:58]
|   :PROPERTIES:
|   :LOGGING: nologging
|   :LOGGING: nologrepeat
|   :END:  
| * DONE three
|   SCHEDULED: <2008-02-14 Thu> CLOSED: [2008-02-15 Fri 09:58]
|   - State "DONE"       [2008-02-15 Fri 09:58]
|   :PROPERTIES:
|   :LOGGING: nologging
|   :END:
| *** DONE One Two Three
|     CLOSED: [2008-02-15 Fri 09:58]
|     - State "DONE"       [2008-02-15 Fri 09:58]
|     
`----

,----[ from org.texi ]
| nologging        @r{don't record when items are marked DONE}
`----

So is that

  - don't record the CLOSED: [date goes here] line
  - or don't record the - State "DONE" [date goes here] line
  - or both?

I'm still confused :)

-Bernt

Re: Bug: LOGGING property does not stop asking for a note

[J. David Boyd]

Didn't Carsten say that this would be in 5.22, and the current git
master?  You are still use 5.21, unless you went and got the
latest....


Bernt Hansen <bernt@norang.ca> writes:

> Carsten Dominik <dominik@science.uva.nl> writes:
>
>> I have now fixed this, just pushed it into the git repo.
>>
>> Here is the setup that you would need.  Please note:
>>
>> (1) Starting from 5.22, in fact starting with the current git master,
>>     you should be using org-log-progress instead of org-log-done which
>>     is now obsolete and only an alias for org-log-progress.
>> (2) For the repeating entry you need to turn off with both
>>     nologging and nologrepeat.
>> (3) Use nologging here.

Re: Bug: LOGGING property does not stop asking for a note

[Bernt Hansen]

I updated to the current git master first.  (5.21+)

david@adboyd.com (J. David Boyd) writes:

> Didn't Carsten say that this would be in 5.22, and the current git
> master?  You are still use 5.21, unless you went and got the
> latest....
>
>
> Bernt Hansen <bernt@norang.ca> writes:
>
>> Carsten Dominik <dominik@science.uva.nl> writes:
>>
>>> I have now fixed this, just pushed it into the git repo.
>>>
>>> Here is the setup that you would need.  Please note:
>>>
>>> (1) Starting from 5.22, in fact starting with the current git master,
>>>     you should be using org-log-progress instead of org-log-done which
>>>     is now obsolete and only an alias for org-log-progress.
>>> (2) For the repeating entry you need to turn off with both
>>>     nologging and nologrepeat.
>>> (3) Use nologging here.
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Bug: LOGGING property does not stop asking for a note

[J. David Boyd]

I was _certain_ you had, just thought I'd mention it!



Bernt Hansen <bernt@norang.ca> writes:

> I updated to the current git master first.  (5.21+)
>
> david@adboyd.com (J. David Boyd) writes:
>
>> Didn't Carsten say that this would be in 5.22, and the current git
>> master?  You are still use 5.21, unless you went and got the
>> latest....
>>
>>
>> Bernt Hansen <bernt@norang.ca> writes:
>>
>>> Carsten Dominik <dominik@science.uva.nl> writes:
>>>
>>>> I have now fixed this, just pushed it into the git repo.
>>>>
>>>> Here is the setup that you would need.  Please note:
>>>>
>>>> (1) Starting from 5.22, in fact starting with the current git master,
>>>>     you should be using org-log-progress instead of org-log-done which
>>>>     is now obsolete and only an alias for org-log-progress.
>>>> (2) For the repeating entry you need to turn off with both
>>>>     nologging and nologrepeat.
>>>> (3) Use nologging here.
>>
>>
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Remember: use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Bug: LOGGING property does not stop asking for a note

[Carsten Dominik]

Yes, still some bugs in there, I am reconsidering how to do this, so
please hang on for a while.

- Carsten

On Feb 15, 2008, at 4:10 PM, Bernt Hansen wrote:

> Carsten Dominik <dominik@science.uva.nl> writes:
>
>> I have now fixed this, just pushed it into the git repo.
>>
>> Here is the setup that you would need.  Please note:
>>
>> (1) Starting from 5.22, in fact starting with the current git master,
>>    you should be using org-log-progress instead of org-log-done which
>>    is now obsolete and only an alias for org-log-progress.
>> (2) For the repeating entry you need to turn off with both
>>    nologging and nologrepeat.
>> (3) Use nologging here.
>>
>> If you have the time, maybe you'd enjoy summarizing this again in a
>> message, and then linking to it from the Worg FAQ?
>
> Thanks!!  I'll add an org task to update the Worg FAQ after I get this
> all straight in my head. :)
>
> How do you set both nologging and nologrepeat in properties?  Like  
> this?
>
>    :PROPERTIES:
>    :LOGGING:  nologging
>    :LOGGING:  nologrepeat
>    :END:
>
> I've removed my org-log-done setting and changed my todo tag  
> definitions
> to
>
> (setq org-todo-keywords
>      '((sequence "TODO(t)" "NEXT(n)" "WAITING(w@)" "SOMEDAY(s!)" "|"  
> "DONE(d!)" "CANCELLED(c@)")))
>
> and completing the repeated task still adds an entry for
>
>    - State "DONE"       [2008-02-15 Fri 09:49]
>
> So I must still be doing something wrong...
> I thought nologging was supposed to turn that off.
>
> Org-mode version 5.21+
> GNU Emacs 22.1.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars)  
> of 2007-11-03 on pacem, modified by Debian
>
> ,----[ minimal.emacs ]
> | (setq org-todo-keywords
> |       '((sequence "TODO(t)" "NEXT(n)" "WAITING(w@)" "SOMEDAY(s!)"  
> "|" "DONE(d!)" "CANCELLED(c@)")))
> | (setq inhibit-splash-screen t)
> | (global-font-lock-mode t)
> | (add-to-list 'load-path (expand-file-name "~/git/org-mode"))
> | (add-to-list 'auto-mode-alist '("\\.org$" . org-mode))
> | (require 'org-install)
> | (define-key global-map "\C-ca" 'org-agenda)
> | (custom-set-variables
> |  '(org-agenda-files (quote ("~/org/test.org"))))
> | (org-agenda-list)
> `----
>
> ,----[ test.org ]
> | * TODO one
> |   SCHEDULED: <2008-02-14 Thu>
> | * TODO two
> |   SCHEDULED: <2008-03-27 Thu +1w>
> |   :PROPERTIES:
> |   :LOGGING: nologging
> |   :LOGGING: nologrepeat
> |   :END:
> | * TODO three
> |   SCHEDULED: <2008-02-14 Thu>
> |   :PROPERTIES:
> |   :LOGGING: nologging
> |   :END:
> | *** TODO One Two Three
> |
> `----
>
> Then if I change each task to DONE I get this
> (no prompts for a closing note -- yay!)
>
> ,----[ test.org ]
> | * DONE one
> |   SCHEDULED: <2008-02-14 Thu> CLOSED: [2008-02-15 Fri 09:58]
> |   - State "DONE"       [2008-02-15 Fri 09:58]
> | * TODO two
> |   SCHEDULED: <2008-04-03 Thu +1w>
> |   - State "DONE"       [2008-02-15 Fri 09:58]
> |   :PROPERTIES:
> |   :LOGGING: nologging
> |   :LOGGING: nologrepeat
> |   :END:
> | * DONE three
> |   SCHEDULED: <2008-02-14 Thu> CLOSED: [2008-02-15 Fri 09:58]
> |   - State "DONE"       [2008-02-15 Fri 09:58]
> |   :PROPERTIES:
> |   :LOGGING: nologging
> |   :END:
> | *** DONE One Two Three
> |     CLOSED: [2008-02-15 Fri 09:58]
> |     - State "DONE"       [2008-02-15 Fri 09:58]
> |
> `----
>
> ,----[ from org.texi ]
> | nologging        @r{don't record when items are marked DONE}
> `----
>
> So is that
>
>  - don't record the CLOSED: [date goes here] line
>  - or don't record the - State "DONE" [date goes here] line
>  - or both?
>
> I'm still confused :)
>
> -Bernt