[bug] ox-koma-letter.el: Double translation of the signature to LaTeX

[bug] ox-koma-letter.el: Double translation of the signature to LaTeX

[Tobias Zawada]

Hello,
org-export-data for the signature causes double LaTeX translation at https://emacs.stackexchange.com/questions/42200/prevent-org-export-from-expanding-as-backslash/42207?noredirect=1#comment66334_42207.

The translator for the headlines org-koma-letter-headline is used to extract the :closing: headline and to put its stuff into org-koma-letter-special-contents. org-koma-letter--get-tagged-contents retrieves the closing from there. I have the impression that org-koma-letter-headline already gets the translated headline contents and translating it again with org-export-data is a bad idea.


Regards,
Tobias


The following changes since commit 96b9166cf47e33a0e0292eee0eb8f42190c9c9fd:
Add header argument :save-windows. (2018-06-20 00:21:09 +0200)
are available in the Git repository at:
https://code.orgmode.org/TobiasZawada/org-mode.git HEAD
for you to fetch changes up to 69ee47c34bb0c857b2db2433b38c2ba980ea3905:
Avoid double data export on :closing: header content (2018-06-23 22:13:00 +0200)

----------------------------------------------------------------
Tobias Zawada (1):
 Avoid double data export on :closing: header content

contrib/lisp/ox-koma-letter.el | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/contrib/lisp/ox-koma-letter.el b/contrib/lisp/ox-koma-letter.el
index fc6599fe7..8d9b5ef6b 100644
--- a/contrib/lisp/ox-koma-letter.el
+++ b/contrib/lisp/ox-koma-letter.el
@@ -820,9 +820,8 @@ a communication channel."
 (and (plist-get info :with-headline-opening)
 (org-string-nw-p
 (org-trim
- (org-export-data
- (org-koma-letter--get-tagged-contents 'closing)
- info)))))
+ (org-koma-letter--get-tagged-contents 'closing)
+ info))))
 (signature (org-string-nw-p (plist-get info :signature)))
 (signature-scope (funcall check-scope 'signature)))
 (and (or (and signature signature-scope)

Re: [bug] ox-koma-letter.el: Double translation of the signature to LaTeX

[Nicolas Goaziou]

Hello,

Tobias Zawada <i_inbox@tn-home.de> writes:

> org-export-data for the signature causes double LaTeX translation at
> https://emacs.stackexchange.com/questions/42200/prevent-org-export-from-expanding-as-backslash/42207?noredirect=1#comment66334_42207.
>
> The translator for the headlines org-koma-letter-headline is used to
> extract the :closing: headline and to put its stuff into
> org-koma-letter-special-contents. org-koma-letter--get-tagged-contents
> retrieves the closing from there. I have the impression that
> org-koma-letter-headline already gets the translated headline contents
> and translating it again with org-export-data is a bad idea.

Correct.

>  (org-trim
> - (org-export-data
> - (org-koma-letter--get-tagged-contents 'closing)
> - info)))))
> + (org-koma-letter--get-tagged-contents 'closing)
> + info))))

This will fail if `org-koma-letter--get-tagged-contents' returns a nil
value. I applied a slightly different patch.

Thank you for the analysis and the patch.

Regards,

-- 
Nicolas Goaziou