emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Max Nikulin <manikulin@gmail.com>
To: Janek F <xerusx@pm.me>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: [BUG] org-attach-id-ts-folder-format fails on customized IDs [9.6 (9.6-??-2e9999783)]
Date: Sat, 13 Aug 2022 22:59:18 +0700	[thread overview]
Message-ID: <114c31b1-b4f4-80b1-50d0-d6f46b84effc@gmail.com> (raw)
In-Reply-To: <8g4g55i6XsG-C0vN8LdPLL-p4BxnXTCU8wzPQ1eSYSFQu_Bl8joOYGD53lfOvoA7Po9TfZXdNXYsuOM_ToD8IVAZyr8SKxk2Yl2OpN4Xb1g=@pm.me>

On 12/08/2022 23:08, Janek F wrote:
> I use org-roam which creates links between org-files using the ID, and I
> would like to be able to manually add such links to common pages even if
> autocompletion doesn't work smoothly.

Unfortunately I have not tried org-roam yet. My suggestion is to add 
CUSTOM_ID property in addition to ID. I admit that CUSTOM_ID may be 
inconvenient if a heading is moved from one file to another. Are there 
more problems with CUSTOM_ID links?

> Considering the other messages, let's not get lost in details, the
> default function does not need to consider all edge cases. It simply
> should not error out on ids in a different format.

Janek, what is your expectation concerning directory structure for 
attachments in the case of customized ID values?

You have not provided details concerning your configuration, but perhaps 
your issue may be solved by customizing 
`org-attach-id-to-path-function-list': keep 
`org-attach-id-uuid-folder-format' and drop 
`org-attach-id-ts-folder-format'. It should help unless you have single 
character IDs.

I do not think Org behavior is ideal in your case. On the other hand the 
code was written with assumption that either UUID or timestamp-based IDs 
are used. It is violated by handcrafted IDs. I do not know the full 
story, but I guess, `org-attach-id-ts-folder-format' is present in 
default configuration for backward compatibility reasons.

org-attach-id-ts-folder-format: Args out of range: "ftt", 0, 6

is an obscure error. However Org needs some hint from user how to handle 
such case.


      parent reply	other threads:[~2022-08-13 16:01 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20 19:12 [BUG] org-attach-id-ts-folder-format fails on customized IDs [9.6 (9.6-??-2e9999783)] Janek F
2022-07-23  5:22 ` [PATCH] " Ihor Radchenko
2022-08-02 22:26   ` Janek F
2022-08-03 16:03   ` Max Nikulin
2022-08-03 22:25     ` Ihor Radchenko
2022-08-10 11:43       ` [PATCH v2] " Ihor Radchenko
2022-08-10 12:17         ` Max Nikulin
2022-08-10 13:23           ` [PATCH v3] " Ihor Radchenko
2022-08-10 15:18             ` Max Nikulin
2022-08-11  4:19               ` Ihor Radchenko
2022-08-11 14:43                 ` Max Nikulin
2022-08-13  5:29                   ` Ihor Radchenko
2022-08-13 16:25                     ` Max Nikulin
2022-08-14  4:00                       ` Ihor Radchenko
2022-10-02  9:14                         ` [PATCH v4] " Ihor Radchenko
2022-10-04 15:27                           ` Max Nikulin
2022-10-05  5:44                             ` Ihor Radchenko
2022-11-06  7:43                               ` Ihor Radchenko
2022-11-07 17:05                               ` [PATCH] org-attach.el: ID to path functions may return nil Max Nikulin
2022-11-08  5:08                                 ` Ihor Radchenko
2022-11-09 16:53                                   ` [PATCH v2] " Max Nikulin
2022-11-10  7:19                                     ` Ihor Radchenko
2022-11-13 16:26                                       ` Max Nikulin
2022-11-14  3:29                                         ` Ihor Radchenko
2022-11-14 16:59                                           ` Max Nikulin
2022-11-15  2:41                                             ` Ihor Radchenko
2022-11-15 16:41                                               ` Max Nikulin
2022-11-16  1:54                                                 ` Ihor Radchenko
2022-08-12 15:35 ` [BUG] org-attach-id-ts-folder-format fails on customized IDs [9.6 (9.6-??-2e9999783)] Max Nikulin
2022-08-12 16:08   ` Janek F
2022-08-13  5:17     ` Ihor Radchenko
2022-08-13 15:59     ` Max Nikulin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=114c31b1-b4f4-80b1-50d0-d6f46b84effc@gmail.com \
    --to=manikulin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=xerusx@pm.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).