From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dokos Subject: Re: Tangling is broken in git master Date: Mon, 13 Aug 2012 11:38:43 -0400 Message-ID: <11277.1344872323@alphaville> References: <87628oncqa.fsf@norang.ca> <871ujc33gd.fsf@gnu.org> <87lihj7dyw.fsf@norang.ca> <87sjbrs5wh.fsf@gnu.org> <877gt2sy83.fsf@gmx.com> <87r4rayjxu.fsf@gnu.org> <87obmeg9il.fsf@gmx.com> <10731.1344869187@alphaville> <87pq6ux2pk.fsf@gnu.org> Reply-To: nicholas.dokos@hp.com Return-path: Received: from eggs.gnu.org ([208.118.235.92]:44578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0wjI-0003vM-Iq for emacs-orgmode@gnu.org; Mon, 13 Aug 2012 11:39:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T0wjH-0001N3-JP for emacs-orgmode@gnu.org; Mon, 13 Aug 2012 11:38:56 -0400 In-Reply-To: Message from Bastien of "Mon, 13 Aug 2012 16:53:59 +0200." <87pq6ux2pk.fsf@gnu.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: Bernt Hansen , emacs-orgmode@gnu.org, Eric Schulte Bastien wrote: > Hi Nick, > > Nick Dokos writes: > > > Can't the definition of letrec in emacs24 be lifted bodily into org-compat.el > > (or whatever the correct place is) as a compatibility-with-emacs-23 macro? > > I don't think it's worth the effort. > > The current code works and compiles without warnings for the user. > What about future code? IME, it's always worthwhile to be thinking about ways to avoid future bugs. > Getting rid of org-flet was to make things a bit more "elispy", > but I'm fine with `org-labels' and those four lines of warnings- > for-developers-only. > It's more the freedom that it gives to developers (i.e Eric S. :-) ) who are used to writing code a certain way: the way it is now, they've got to keep in mind that letrec is not valid for emacs23 and write the code differently - I'd suggest that that can be a source of bugs that would be avoided with a compatibility macro. But maybe the compatibility macro would be a bigger problem - I don't know for sure. In particular, the file would need a periodic cleanup to get rid of old cruft, but if it's a once-a-year-or-two occurrence, that might not be too bad. Nick