From: Keith Packard <keithp@keithp.com>
To: Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org
Subject: Re: _notmuch_message_create_for_message_id makes extra call to notmuch_database_find_message
Date: Fri, 27 Nov 2009 10:10:58 -0800 [thread overview]
Message-ID: <yun7htbet3h.fsf@aiko.keithp.com> (raw)
In-Reply-To: <87iqcwqgn5.fsf@yoom.home.cworth.org>
[-- Attachment #1: Type: text/plain, Size: 496 bytes --]
On Fri, 27 Nov 2009 04:46:54 -0800, Carl Worth <cworth@cworth.org> wrote:
> Did the "if" statement immediately afterwards just look like error
> checking? It's not:
Yes, it did (I think my brain may have auto-inserted a '!' there).
Ok, having read the code a bit more carefully, this does look correct.
I have to say that _notmuch_message_create is a bit of a tricky name; as
it doesn't create a message so much as load a message from the database.
--
keith.packard@intel.com
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2009-11-27 18:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-23 20:29 _notmuch_message_create_for_message_id makes extra call to notmuch_database_find_message Keith Packard
2009-11-27 12:46 ` Carl Worth
2009-11-27 18:10 ` Keith Packard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yun7htbet3h.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=cworth@cworth.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).