From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 572F8429E3D for ; Wed, 4 Jan 2012 06:35:34 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RIA9t7J1Berd for ; Wed, 4 Jan 2012 06:35:33 -0800 (PST) Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 83B9D429E21 for ; Wed, 4 Jan 2012 06:35:33 -0800 (PST) Received: from pps.filterd (mail-gw3 [127.0.0.1]) by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id q04EZUPi024411; Wed, 4 Jan 2012 16:35:30 +0200 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31]) by mail-gw3.nixu.fi with ESMTP id 114cs0xbbm-1 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Wed, 04 Jan 2012 16:35:30 +0200 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31]) by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id q04EZTUB009265; Wed, 4 Jan 2012 16:35:29 +0200 From: Tomi Ollila To: Jani Nikula , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: call "notmuch tag" only once when archiving a thread In-Reply-To: <1325615346-8302-1-git-send-email-jani@nikula.org> References: <1325615346-8302-1-git-send-email-jani@nikula.org> User-Agent: Notmuch/0.10.2+157~g442d405 (http://notmuchmail.org) Emacs/23.3.1 (i686-pc-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110, 1.0.211, 0.0.0000 definitions=2012-01-04_06:2012-01-04, 2012-01-04, 1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 ipscore=0 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=6.0.2-1012030000 definitions=main-1201040113 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2012 14:35:34 -0000 On Tue, 3 Jan 2012 20:29:06 +0200, Jani Nikula wrote: > Optimize thread archiving by combining all the -inbox tagging operations to > a single "notmuch tag" call. Also skip redisplay of tag changes in current > buffer, as it is immediately killed by the archiving functions. > > For threads in the order of tens or a hundred inbox tagged messages, this > gives a noticeable speedup. > > On the downside, IIRC Xapian does not perform very well if the query (in > this case a lot of message-ids OR'd together) is very big. It is unknown to > me at which point this approach would become slower than the original one > by one tagging approach, if ever. > > Also, this introduces a limitation to the number of messages that can be > archived at the same time (through ARG_MAX limiting the command line). At > least on Linux this seems more like a theoretical limitation than a real > one. IIRC some systems have like 32768 byte command line limit. If the change did tagging in like 100-message batches then this limit is hardly exceeded (if message-id's max 80 characters then command line is 8000+ bytes)... Hmm -- is there a length limit for message-id. If not maybe when appending message id's keep counting length and tag in batches based on that lenght value. Hundreds of messages per tagging operation instead of one is good improvements. > Signed-off-by: Jani Nikula Tomi