* [PATCH] remove GCC visibility pragmas
@ 2011-10-31 12:01 Tomi Ollila
2011-10-31 12:07 ` David Bremner
0 siblings, 1 reply; 3+ messages in thread
From: Tomi Ollila @ 2011-10-31 12:01 UTC (permalink / raw
To: notmuch
libnotmuch.so.* linking fail on some environments. According to
David Bremner on irc:
"We jump through hoops with the linker script (notmuch.sym) so
the pragmas are not needed. And they are a little bizarre in a
library anyway..."
---
util/xutil.h | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/util/xutil.h b/util/xutil.h
index 9299256..b84e0e2 100644
--- a/util/xutil.h
+++ b/util/xutil.h
@@ -25,8 +25,6 @@
#include <sys/types.h>
#include <regex.h>
-#pragma GCC visibility push(hidden)
-
/* xutil.c */
void *
xcalloc (size_t nmemb, size_t size);
@@ -51,6 +49,4 @@ int
xregexec (const regex_t *preg, const char *string,
size_t nmatch, regmatch_t pmatch[], int eflags);
-#pragma GCC visibility pop
-
#endif
--
1.7.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] remove GCC visibility pragmas
2011-10-31 12:01 [PATCH] remove GCC visibility pragmas Tomi Ollila
@ 2011-10-31 12:07 ` David Bremner
2011-10-31 12:19 ` Tomi Ollila
0 siblings, 1 reply; 3+ messages in thread
From: David Bremner @ 2011-10-31 12:07 UTC (permalink / raw
To: Tomi Ollila, notmuch
On Mon, 31 Oct 2011 14:01:28 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> libnotmuch.so.* linking fail on some environments. According to
> David Bremner on irc:
> "We jump through hoops with the linker script (notmuch.sym) so
> the pragmas are not needed. And they are a little bizarre in a
> library anyway..."
Despite the dubious people referenced, I pushed this patch.
;)
d
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] remove GCC visibility pragmas
2011-10-31 12:07 ` David Bremner
@ 2011-10-31 12:19 ` Tomi Ollila
0 siblings, 0 replies; 3+ messages in thread
From: Tomi Ollila @ 2011-10-31 12:19 UTC (permalink / raw
To: David Bremner; +Cc: notmuch
On Mon 31 Oct 2011 14:07, David Bremner <david@tethera.net> writes:
> On Mon, 31 Oct 2011 14:01:28 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
>> libnotmuch.so.* linking fail on some environments. According to
>> David Bremner on irc:
>> "We jump through hoops with the linker script (notmuch.sym) so
>> the pragmas are not needed. And they are a little bizarre in a
>> library anyway..."
>
> Despite the dubious people referenced, I pushed this patch.
I apologize not asking you about the commit message before sending;
have to remember discuss privately first next time in similar cases.
I did some internet searching to verify that I can agree to the above (but
didn't take part of praise/blame for it).
> ;)
>
> d
Tomi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-31 12:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-31 12:01 [PATCH] remove GCC visibility pragmas Tomi Ollila
2011-10-31 12:07 ` David Bremner
2011-10-31 12:19 ` Tomi Ollila
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).