unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] remove GCC visibility pragmas
Date: Mon, 31 Oct 2011 14:19:52 +0200	[thread overview]
Message-ID: <yf6ty6pe4k7.fsf@taco2.nixu.fi> (raw)
In-Reply-To: <8762j5icuu.fsf@convex-new.cs.unb.ca> (David Bremner's message of "Mon, 31 Oct 2011 09:07:05 -0300")

On Mon 31 Oct 2011 14:07, David Bremner <david@tethera.net> writes:

> On Mon, 31 Oct 2011 14:01:28 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
>> libnotmuch.so.* linking fail on some environments. According to
>> David Bremner on irc:
>>  "We jump through hoops with the linker script (notmuch.sym) so
>>  the pragmas are not needed. And they are a little bizarre in a
>>  library anyway..."
>
> Despite the dubious people referenced, I pushed this patch.

I apologize not asking you about the commit message before sending;
have to remember discuss privately first next time in similar cases. 
I did some internet searching to verify that I can agree to the above (but
didn't take part of praise/blame for it).

> ;)
>
> d


Tomi

      reply	other threads:[~2011-10-31 12:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-31 12:01 [PATCH] remove GCC visibility pragmas Tomi Ollila
2011-10-31 12:07 ` David Bremner
2011-10-31 12:19   ` Tomi Ollila [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yf6ty6pe4k7.fsf@taco2.nixu.fi \
    --to=tomi.ollila@iki.fi \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).