unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/9] test: (hopefully) better test prerequisites
Date: Fri, 18 Nov 2011 10:55:30 +0200	[thread overview]
Message-ID: <yf6ty6195dp.fsf@taco2.nixu.fi> (raw)
In-Reply-To: <87zkfun5hf.fsf@gmail.com>

On Thu, 17 Nov 2011 19:17:16 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> 
> If we follow this pattern than all code like:
> 
>   f() {
>     if (!done_once)
>         do_once
> 
>     do_more
>   }
> 
> Should be rewritten using dynamic functions. I do not think I agree with
> this :)
> 
> Anyway, all above is just IMHO.  You should probably go ahead and
> prepare a patch implementing this approach for others to review.

I probably won't. While I was looking something in your patch and I was
thinking how to fix I just got this idea and wrote it to see whether
other's see as I do. The discussion got a bit side-tracked as I just
look this tiny part of the whole. Your later patch looks more
understandable than the previous (which emacs || emacs || return) and
it is something I can live with :) -- Just for now I'm not going to 
work on the whole anyway.

> 
> Regards,
>   Dmitry
> 

Thanks,
Tomi

  reply	other threads:[~2011-11-18  8:55 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-17  1:56 [PATCH 0/9] test: (hopefully) better test prerequisites Dmitry Kurochkin
2011-11-17  1:56 ` [PATCH 1/9] test: move subtest variables reset into a dedicated function Dmitry Kurochkin
2011-11-17  1:56 ` [PATCH 2/9] test: set EMACS_SERVER variable only after dtach(1) was successfully started Dmitry Kurochkin
2011-11-17  9:14   ` Jameson Graef Rollins
2011-11-17 11:07     ` Dmitry Kurochkin
2011-11-17  1:56 ` [PATCH 3/9] test: add test state reset to test_expect_* functions that did not have it Dmitry Kurochkin
2011-11-17  1:56 ` [PATCH 4/9] test: add support for external executable dependencies Dmitry Kurochkin
2011-11-28 21:16   ` Tomi Ollila
2011-11-28 21:53     ` Dmitry Kurochkin
2011-11-28 22:13       ` Dmitry Kurochkin
2011-11-28 22:42         ` Dmitry Kurochkin
2011-11-17  1:56 ` [PATCH 5/9] test: fix "skipping test" verbose output Dmitry Kurochkin
2011-11-17  1:56 ` [PATCH 6/9] test: skip all subtests if external dependencies are missing during init Dmitry Kurochkin
2011-11-17  1:56 ` [PATCH 7/9] test: declare external dependencies for the tests Dmitry Kurochkin
2011-11-17  1:56 ` [PATCH 8/9] test: check if emacs is available in the beginning of test_emacs Dmitry Kurochkin
2011-11-17  9:43   ` Tomi Ollila
2011-11-17 11:13     ` Dmitry Kurochkin
2011-11-17 13:08       ` Dmitry Kurochkin
2011-11-17  1:56 ` [PATCH 9/9] test: fix "Stashing in notmuch-search" test when emacs is not available Dmitry Kurochkin
2011-11-17  9:14 ` [PATCH 0/9] test: (hopefully) better test prerequisites Jameson Graef Rollins
2011-11-17 11:20   ` Dmitry Kurochkin
2011-11-17 12:20   ` Tomi Ollila
2011-11-17 12:30     ` Tomi Ollila
2011-11-17 13:22     ` Dmitry Kurochkin
2011-11-17 14:02       ` Tomi Ollila
2011-11-17 15:17         ` Dmitry Kurochkin
2011-11-18  8:55           ` Tomi Ollila [this message]
2011-11-17  9:46 ` Thomas Jost
2011-11-17 11:45   ` Dmitry Kurochkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yf6ty6195dp.fsf@taco2.nixu.fi \
    --to=tomi.ollila@iki.fi \
    --cc=dmitry.kurochkin@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).