From: Tomi Ollila <tomi.ollila@iki.fi>
To: Jani Nikula <jani@nikula.org>, Austin Clements <amdragon@MIT.EDU>,
Aaron Ecay <aaronecay@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: call "notmuch tag" only once when archiving a thread
Date: Mon, 09 Jan 2012 12:38:58 +0200 [thread overview]
Message-ID: <yf6sjjp9n3x.fsf@taco2.nixu.fi> (raw)
In-Reply-To: <87k451clp0.fsf@nikula.org>
On Mon, 09 Jan 2012 08:41:15 +0000, Jani Nikula <jani@nikula.org> wrote:
> On Sun, 8 Jan 2012 20:12:59 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> > Quoth Aaron Ecay on Jan 08 at 7:56 pm:
> > > On Thu, 05 Jan 2012 22:32:16 +0200, Jani Nikula <jani@nikula.org> wrote:
> > >
> > > [...]
> > >
> > > > In the show view it only modifies the messages that are currently
> > > > visible. This is to make sure you don't accidentally archive things that
> > > > have arrived after refreshing the buffer. I think this is safest.
> > >
> > > Hmm. Perhaps it would make sense to add a check in the search view that
> > > the thread being archived[1] has the same number of messages as it did
> > > when the buffer was constructed. (The information on how many messages
> > > the thread has is in the buffer; we would then compare this to the result
> > > of “notmuch count thread:000foo” when the user requests to archive.) If
> > > the counts don’t match, the interface should show a message in the echo
> > > area and (probably) refuse to do the tagging.
> >
> > That sounds like a clever workaround.
>
> The downside is that there's still a race condition: you could get new
> messages between checking the number of messages in the thread and
> tagging. The window for error would be much smaller than now, but it's
> still there. (You could check afterwards if this happened, and notify
> the user, "oooops, I just tagged N messages more than you intended"...)
And this could also be "false alarm" if the the new messages arrived
after tagging but before checking...
>
> J.
Tomi
next prev parent reply other threads:[~2012-01-09 10:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 18:29 [PATCH] emacs: call "notmuch tag" only once when archiving a thread Jani Nikula
2012-01-04 14:13 ` David Edmondson
2012-01-04 14:35 ` Tomi Ollila
2012-01-05 20:10 ` Aaron Ecay
2012-01-05 20:32 ` Jani Nikula
2012-01-05 20:38 ` Jameson Graef Rollins
2012-01-05 20:58 ` Jani Nikula
2012-01-06 21:31 ` Tomi Ollila
2012-01-09 0:56 ` Aaron Ecay
2012-01-09 1:12 ` Austin Clements
2012-01-09 8:15 ` David Edmondson
2012-01-09 8:41 ` Jani Nikula
2012-01-09 10:38 ` Tomi Ollila [this message]
2012-01-09 10:46 ` David Edmondson
2012-01-09 11:31 ` Mark Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yf6sjjp9n3x.fsf@taco2.nixu.fi \
--to=tomi.ollila@iki.fi \
--cc=aaronecay@gmail.com \
--cc=amdragon@MIT.EDU \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).