From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 75F85429E2F for ; Wed, 14 Dec 2011 04:26:43 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wGL8r4Hsx7yz for ; Wed, 14 Dec 2011 04:26:42 -0800 (PST) Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id A3094429E26 for ; Wed, 14 Dec 2011 04:26:42 -0800 (PST) Received: from pps.filterd (mail-gw3 [127.0.0.1]) by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id pBECNMmQ009797; Wed, 14 Dec 2011 14:26:39 +0200 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31]) by mail-gw3.nixu.fi with ESMTP id 114cs0t9he-1 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Wed, 14 Dec 2011 14:26:39 +0200 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31]) by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id pBECQdc1016564; Wed, 14 Dec 2011 14:26:39 +0200 From: Tomi Ollila To: Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org Subject: Re: [PATCH 6/7] py3k: Add and use a mixin class that implements __str__ In-Reply-To: <1323860305-15802-7-git-send-email-4winter@informatik.uni-hamburg.de> References: <1323860305-15802-1-git-send-email-4winter@informatik.uni-hamburg.de> <1323860305-15802-7-git-send-email-4winter@informatik.uni-hamburg.de> User-Agent: Notmuch/0.10.2+93~g631d290 (http://notmuchmail.org) Emacs/23.3.1 (i686-pc-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110, 1.0.211, 0.0.0000 definitions=2011-12-14_05:2011-12-14, 2011-12-14, 1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 ipscore=0 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=6.0.2-1012030000 definitions=main-1112140075 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Dec 2011 12:26:43 -0000 On Wed, 14 Dec 2011 11:58:24 +0100, Justus Winter <4winter@informatik.uni-hamburg.de> wrote: > --- [ ... snip ... ] > > -class Filenames(object): > +class Filenames(Python3StringMixIn): > """Represents a list of filenames as returned by notmuch > > This object contains the Filenames iterator. The main function is > @@ -98,9 +98,6 @@ class Filenames(object): > > self._files = None > > - def __str__(self): > - return unicode(self).encode('utf-8') > - > def __unicode__(self): > """Represent Filenames() as newline-separated list of full paths > > diff --git a/bindings/python/notmuch/globals.py b/bindings/python/notmuch/globals.py > index c52790c..2111b86 100644 > --- a/bindings/python/notmuch/globals.py > +++ b/bindings/python/notmuch/globals.py > @@ -28,6 +28,16 @@ except: > raise ImportError("Could not find shared 'notmuch' library.") > > > +if sys.version_info[0] == 2: > + class Python3StringMixIn(object): > + def __str__(self): > + return unicode(self).encode('utf-8') > +else: > + class Python3StringMixIn(object): > + def __str__(self): > + return self.__unicode__() > + > + [ ... snip ... ] > -class Threads(object): > +class Threads(Python3StringMixIn): > """Represents a list of notmuch threads > > This object provides an iterator over a list of notmuch threads > @@ -393,7 +393,7 @@ class Thread(object): > return Tags(tags_p, self) > > def __str__(self): > - return unicode(self).encode('utf-8') > + return self.__unicode__().encode('utf-8') > > def __unicode__(self): > frm = "thread:%s %12s [%d/%d] %s; %s (%s)" Is this class special case ? in all other classes the __str__() function has been removed (using inherited function) ? > -- > 1.7.7.3 Otherwise LGTM -- pretty simple and effective (all 7 patches). Tomi