unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
	Notmuch Mail <notmuch@notmuchmail.org>
Subject: [PATCH] test: use dtach(1) instead of screen(1) in emacs tests.
Date: Fri, 11 Nov 2011 00:03:14 +0200	[thread overview]
Message-ID: <yf6mxc3ab4t.fsf@taco2.nixu.fi> (raw)
In-Reply-To: <1320953702-16732-1-git-send-email-jrollins@finestructure.net>

dtach is lighter than screen and is not setuid/setgid program so
TMPDIR does not get reset by dynamic loader when executed.
---
 test/test-lib.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/test-lib.sh b/test/test-lib.sh
index c81c709..af723ad 100755
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -844,8 +844,8 @@ test_emacs () {
 	if [ -z "$EMACS_SERVER" ]; then
 		EMACS_SERVER="notmuch-test-suite-$$"
 		# start a detached screen session with an emacs server
-		screen -S "$EMACS_SERVER" -d -m "$TMP_DIRECTORY/run_emacs" \
-			--no-window-system \
+		TERM=xterm dtach -n "$TMP_DIRECTORY/dtach-emacs-socket-$$" \
+			"$TMP_DIRECTORY/run_emacs" --no-window-system \
 			--eval "(setq server-name \"$EMACS_SERVER\")" \
 			--eval '(server-start)' \
 			--eval "(orphan-watchdog $$)" || return
-- 
1.5.6.5

  reply	other threads:[~2011-11-10 22:03 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <id:878vnomntf.fsf@servo.finestructure.net>
2011-11-10 16:59 ` [PATCH] test: Use env to set TMPDIR when running emacs in screen Jameson Graef Rollins
2011-11-10 17:09   ` Jameson Graef Rollins
2011-11-10 19:28   ` Austin Clements
2011-11-10 19:35     ` Jameson Graef Rollins
2011-11-10 22:03       ` Tomi Ollila [this message]
2011-11-10 22:22         ` [PATCH] test: use dtach(1) instead of screen(1) in emacs tests Jameson Graef Rollins
2011-11-11  0:17           ` Pieter Praet
2011-11-11  8:09             ` Tomi Ollila
2011-11-15 16:53               ` Pieter Praet
2011-11-11  0:17           ` [PATCH 1/2] debian: clean up Uploaders and Build-Depends fields in debian/control Jameson Graef Rollins
2011-11-11  0:17             ` [PATCH 2/2] debian: update build dependency on dtach instead of screen Jameson Graef Rollins
2011-11-12  4:27               ` David Bremner
2011-11-12  4:27             ` [PATCH 1/2] debian: clean up Uploaders and Build-Depends fields in debian/control David Bremner
2011-11-11  8:41           ` [PATCH] test: use dtach(1) instead of screen(1) in emacs tests Dmitry Kurochkin
2011-11-11 11:29             ` Tomi Ollila
2011-11-11 16:02               ` Dmitry Kurochkin
2011-11-11 22:51                 ` Jameson Graef Rollins
2011-11-11 20:48           ` Tomi Ollila
2011-11-11 21:06             ` Dmitry Kurochkin
2011-11-11 21:15               ` Tomi Ollila
2011-11-11 21:33                 ` Tomi Ollila
2011-11-12  4:26                   ` David Bremner
2011-11-11 20:49           ` Tomi Ollila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yf6mxc3ab4t.fsf@taco2.nixu.fi \
    --to=tomi.ollila@iki.fi \
    --cc=jrollins@finestructure.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).