* Emacs: notmuch-show-mode failing to actually update tags
@ 2011-10-25 13:25 Erlend Simonsen
2011-10-25 17:32 ` Jameson Graef Rollins
0 siblings, 1 reply; 13+ messages in thread
From: Erlend Simonsen @ 2011-10-25 13:25 UTC (permalink / raw)
To: notmuch
I've been toying around with notmuch the last few days, and I'm having
some problems with the Emacs mode.
Updating tags from the search result is fine (except it doesn't reapply
the tag-faces when changed), but all updates done while viewing a single
message/thread end up being ignored as the message id is quoted.
Example call that doesn't actually update the tags when called from
notmuch-show-mode:
(notmuch-call-notmuch-process (("tag" "-unread" "--"
"id:\"1319481298-2837-1-git-send-email-aidecoe@aidecoe.name\""))
Note the quotes around the id search string. If I remove those, it works.
-- Erlend
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Emacs: notmuch-show-mode failing to actually update tags
2011-10-25 13:25 Emacs: notmuch-show-mode failing to actually update tags Erlend Simonsen
@ 2011-10-25 17:32 ` Jameson Graef Rollins
2011-10-26 7:00 ` Erlend Simonsen
0 siblings, 1 reply; 13+ messages in thread
From: Jameson Graef Rollins @ 2011-10-25 17:32 UTC (permalink / raw)
To: Erlend Simonsen, notmuch
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
On Tue, 25 Oct 2011 15:25:09 +0200, Erlend Simonsen <mr@fudgie.org> wrote:
> I've been toying around with notmuch the last few days, and I'm having
> some problems with the Emacs mode.
>
> Updating tags from the search result is fine (except it doesn't reapply
> the tag-faces when changed), but all updates done while viewing a single
> message/thread end up being ignored as the message id is quoted.
Hi, Erlend. Everything seems to be working for me. Which version are
you running (notmuch --version), and where did you acquire it?
Frequently problems like this happen when the emacs session is not
restarted after a notmuch upgrade. Any chance that applies to your
situation?
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Emacs: notmuch-show-mode failing to actually update tags
2011-10-25 17:32 ` Jameson Graef Rollins
@ 2011-10-26 7:00 ` Erlend Simonsen
2011-10-26 8:17 ` Tomi Ollila
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: Erlend Simonsen @ 2011-10-26 7:00 UTC (permalink / raw)
To: Jameson Graef Rollins, notmuch
On Tue, 25 Oct 2011 10:32:41 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> On Tue, 25 Oct 2011 15:25:09 +0200, Erlend Simonsen <mr@fudgie.org> wrote:
> > I've been toying around with notmuch the last few days, and I'm having
> > some problems with the Emacs mode.
> >
> > Updating tags from the search result is fine (except it doesn't reapply
> > the tag-faces when changed), but all updates done while viewing a single
> > message/thread end up being ignored as the message id is quoted.
>
> Hi, Erlend. Everything seems to be working for me. Which version are
> you running (notmuch --version), and where did you acquire it?
notmuch 0.9-6-g8bb5b62, fetched from git.notmuchmail.org running on GNU
Emacs 24.0.90.1
> Frequently problems like this happen when the emacs session is not
> restarted after a notmuch upgrade. Any chance that applies to your
> situation?
Unfortunately, no. If I run a search for id:"messageid" within Emacs,
nothing is found. But if I search for id:messageid, I get the correct
result. Could this be an Emacs 24 issue?
-- Erlend
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Emacs: notmuch-show-mode failing to actually update tags
2011-10-26 7:00 ` Erlend Simonsen
@ 2011-10-26 8:17 ` Tomi Ollila
2011-10-26 9:19 ` Erlend Simonsen
2011-10-26 15:22 ` Jameson Graef Rollins
2011-10-26 15:23 ` Jameson Graef Rollins
2 siblings, 1 reply; 13+ messages in thread
From: Tomi Ollila @ 2011-10-26 8:17 UTC (permalink / raw)
To: Erlend Simonsen; +Cc: notmuch
On Wed 26 Oct 2011 10:00, Erlend Simonsen <mr@fudgie.org> writes:
> On Tue, 25 Oct 2011 10:32:41 -0700, Jameson Graef Rollins
> <jrollins@finestructure.net> wrote:
>> On Tue, 25 Oct 2011 15:25:09 +0200, Erlend Simonsen <mr@fudgie.org> wrote:
>> > I've been toying around with notmuch the last few days, and I'm having
>> > some problems with the Emacs mode.
>> >
>> > Updating tags from the search result is fine (except it doesn't reapply
>> > the tag-faces when changed), but all updates done while viewing a single
>> > message/thread end up being ignored as the message id is quoted.
>>
>> Hi, Erlend. Everything seems to be working for me. Which version are
>> you running (notmuch --version), and where did you acquire it?
>
> notmuch 0.9-6-g8bb5b62, fetched from git.notmuchmail.org running on GNU
> Emacs 24.0.90.1
>
>> Frequently problems like this happen when the emacs session is not
>> restarted after a notmuch upgrade. Any chance that applies to your
>> situation?
>
> Unfortunately, no. If I run a search for id:"messageid" within Emacs,
> nothing is found. But if I search for id:messageid, I get the correct
> result. Could this be an Emacs 24 issue?
Try these from command line:
notmuch search id:messageid
notmuch search 'id:"messageid"'
Note all the single and double quotes in second line.
These should return the same output. If these does it might
be that your emacs interface escapes the quotes for some reason.
i.e. the execution from emacs is analogous to this command line:
notmuch search 'id:\"messageid\"'
> -- Erlend
Tomi
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Emacs: notmuch-show-mode failing to actually update tags
2011-10-26 8:17 ` Tomi Ollila
@ 2011-10-26 9:19 ` Erlend Simonsen
2011-10-27 15:04 ` Tomi Ollila
0 siblings, 1 reply; 13+ messages in thread
From: Erlend Simonsen @ 2011-10-26 9:19 UTC (permalink / raw)
To: Tomi Ollila; +Cc: notmuch
On Wed, 26 Oct 2011 11:17:15 +0300, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> Try these from command line:
>
> notmuch search id:messageid
~ $ notmuch search id:yf6lis8np4k.fsf@taco2.nixu.fi
thread:0000000000030b25 26 mins. ago [1/4] Tomi Ollila| Erlend Simonsen, Jameson Graef Rollins; Emacs: notmuch-show-mode failing to actually update tags (notmuch replied sent signed to-me)
> notmuch search 'id:"messageid"'
~ $ notmuch search 'id:"yf6lis8np4k.fsf@taco2.nixu.fi"'
> Note all the single and double quotes in second line.
>
> These should return the same output. If these does it might
> be that your emacs interface escapes the quotes for some reason.
> i.e. the execution from emacs is analogous to this command line:
>
> notmuch search 'id:\"messageid\"'
>
As they don't return the same output, where do I dig further to find the
problem?
-- Erlend
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Emacs: notmuch-show-mode failing to actually update tags
2011-10-26 7:00 ` Erlend Simonsen
2011-10-26 8:17 ` Tomi Ollila
@ 2011-10-26 15:22 ` Jameson Graef Rollins
2011-10-26 15:23 ` Jameson Graef Rollins
2 siblings, 0 replies; 13+ messages in thread
From: Jameson Graef Rollins @ 2011-10-26 15:22 UTC (permalink / raw)
To: Erlend Simonsen, notmuch
[-- Attachment #1: Type: text/plain, Size: 528 bytes --]
On Wed, 26 Oct 2011 09:00:51 +0200, Erlend Simonsen <mr@fudgie.org> wrote:
> Unfortunately, no. If I run a search for id:"messageid" within Emacs,
> nothing is found. But if I search for id:messageid, I get the correct
> result. Could this be an Emacs 24 issue?
I am running emacs 23.3 from Debian, and I am not experiencing this
issue, so it may very well be an emacs 24 issue. I would be curious to
know what is going on. I wonder if the call-process function is
automatically trying to shell-escape strings in 24?
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Emacs: notmuch-show-mode failing to actually update tags
2011-10-26 7:00 ` Erlend Simonsen
2011-10-26 8:17 ` Tomi Ollila
2011-10-26 15:22 ` Jameson Graef Rollins
@ 2011-10-26 15:23 ` Jameson Graef Rollins
2011-10-27 8:23 ` Erlend Simonsen
2 siblings, 1 reply; 13+ messages in thread
From: Jameson Graef Rollins @ 2011-10-26 15:23 UTC (permalink / raw)
To: Erlend Simonsen, notmuch
[-- Attachment #1: Type: text/plain, Size: 468 bytes --]
On Wed, 26 Oct 2011 09:00:51 +0200, Erlend Simonsen <mr@fudgie.org> wrote:
> Unfortunately, no. If I run a search for id:"messageid" within Emacs,
> nothing is found. But if I search for id:messageid, I get the correct
> result. Could this be an Emacs 24 issue?
Have you tried running all the unit tests? I would assume that multiple
tests would fail under these conditions, and it might be useful to see
which ones.
You can run the tests with "make test".
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Emacs: notmuch-show-mode failing to actually update tags
2011-10-26 15:23 ` Jameson Graef Rollins
@ 2011-10-27 8:23 ` Erlend Simonsen
2011-10-27 13:57 ` Thomas Jost
0 siblings, 1 reply; 13+ messages in thread
From: Erlend Simonsen @ 2011-10-27 8:23 UTC (permalink / raw)
To: Jameson Graef Rollins, notmuch
On Wed, 26 Oct 2011 08:23:36 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> On Wed, 26 Oct 2011 09:00:51 +0200, Erlend Simonsen <mr@fudgie.org> wrote:
> > Unfortunately, no. If I run a search for id:"messageid" within Emacs,
> > nothing is found. But if I search for id:messageid, I get the correct
> > result. Could this be an Emacs 24 issue?
>
> Have you tried running all the unit tests? I would assume that multiple
> tests would fail under these conditions, and it might be useful to see
> which ones.
>
> You can run the tests with "make test".
These seemed to fail:
FAIL Add tag from notmuch-show view
--- emacs.11.expected 2011-10-27 08:04:40.542525380 +0000
+++ emacs.11.output 2011-10-27 08:04:40.544525353 +0000
@@ -1 +1 @@
-thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox tag-from-show-view unread)
+thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)
nil
FAIL Message with .. in Message-Id:
--- emacs.13.expected 2011-10-27 08:04:40.712523199 +0000
+++ emacs.13.output 2011-10-27 08:04:40.712523199 +0000
@@ -1 +1 @@
-thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; Message with .. in Message-Id (inbox search-add show-add)
+
*ERROR*: Error: notmuch tag requires at least one search term.
<hang for a loooong time>
FATAL: Unexpected exit with code 0
emacs-large-search-buffer: Testing Emacs with large search results buffer
-- Erlend
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Emacs: notmuch-show-mode failing to actually update tags
2011-10-27 8:23 ` Erlend Simonsen
@ 2011-10-27 13:57 ` Thomas Jost
2011-10-27 15:01 ` Jameson Graef Rollins
0 siblings, 1 reply; 13+ messages in thread
From: Thomas Jost @ 2011-10-27 13:57 UTC (permalink / raw)
To: Erlend Simonsen, Jameson Graef Rollins, notmuch
[-- Attachment #1: Type: text/plain, Size: 1414 bytes --]
On Thu, 27 Oct 2011 10:23:48 +0200, Erlend Simonsen <mr@fudgie.org> wrote:
> These seemed to fail:
>
>
> FAIL Add tag from notmuch-show view
> --- emacs.11.expected 2011-10-27 08:04:40.542525380 +0000
> +++ emacs.11.output 2011-10-27 08:04:40.544525353 +0000
> @@ -1 +1 @@
> -thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox tag-from-show-view unread)
> +thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)
> nil
>
> FAIL Message with .. in Message-Id:
> --- emacs.13.expected 2011-10-27 08:04:40.712523199 +0000
> +++ emacs.13.output 2011-10-27 08:04:40.712523199 +0000
> @@ -1 +1 @@
> -thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; Message with .. in Message-Id (inbox search-add show-add)
> +
> *ERROR*: Error: notmuch tag requires at least one search term.
Both of these work for me, both with latest master and 0.9-6-g8bb5b62,
using Emacs-pretest 24.0.90 (compiled it myself) on Arch Linux... Weird.
> <hang for a loooong time>
Yep, issue already reported, it's a problem with smtp-dummy. You can fix
it by applying the patch from this message:
id:"1317660447-27520-14-git-send-email-schnouki@schnouki.net" (or just
killall smtp-dummy several times while running the test suite :))
--
Thomas/Schnouki
[-- Attachment #2: Type: application/pgp-signature, Size: 489 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Emacs: notmuch-show-mode failing to actually update tags
2011-10-27 13:57 ` Thomas Jost
@ 2011-10-27 15:01 ` Jameson Graef Rollins
2011-10-27 15:31 ` Thomas Jost
2011-10-28 9:01 ` Erlend Simonsen
0 siblings, 2 replies; 13+ messages in thread
From: Jameson Graef Rollins @ 2011-10-27 15:01 UTC (permalink / raw)
To: Thomas Jost, Erlend Simonsen, notmuch
[-- Attachment #1: Type: text/plain, Size: 868 bytes --]
On Thu, 27 Oct 2011 15:57:00 +0200, Thomas Jost <schnouki@schnouki.net> wrote:
> Both of these work for me, both with latest master and 0.9-6-g8bb5b62,
> using Emacs-pretest 24.0.90 (compiled it myself) on Arch Linux... Weird.
Erlend, are you sure you don't have anything else in your emacs
environment that may be affecting this? What system do you use? How
was your version of emacs obtained?
> > <hang for a loooong time>
>
> Yep, issue already reported, it's a problem with smtp-dummy. You can fix
> it by applying the patch from this message:
> id:"1317660447-27520-14-git-send-email-schnouki@schnouki.net" (or just
> killall smtp-dummy several times while running the test suite :))
Was this patch not applied? It's part of a series of other patches that
I think *were* applied. I would be curious to know why this one wasn't.
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Emacs: notmuch-show-mode failing to actually update tags
2011-10-26 9:19 ` Erlend Simonsen
@ 2011-10-27 15:04 ` Tomi Ollila
0 siblings, 0 replies; 13+ messages in thread
From: Tomi Ollila @ 2011-10-27 15:04 UTC (permalink / raw)
To: Erlend Simonsen; +Cc: notmuch
On Wed 26 Oct 2011 12:19, Erlend Simonsen <mr@fudgie.org> writes:
> On Wed, 26 Oct 2011 11:17:15 +0300, Tomi Ollila <tomi.ollila@iki.fi> wrote:
>> Try these from command line:
>>
>> notmuch search id:messageid
>
> ~ $ notmuch search id:yf6lis8np4k.fsf@taco2.nixu.fi
> thread:0000000000030b25 26 mins. ago [1/4] Tomi Ollila| Erlend
> Simonsen, Jameson Graef Rollins; Emacs: notmuch-show-mode failing to
> actually update tags (notmuch replied sent signed to-me)
>
>> notmuch search 'id:"messageid"'
>
> ~ $ notmuch search 'id:"yf6lis8np4k.fsf@taco2.nixu.fi"'
>
>> Note all the single and double quotes in second line.
>>
>> These should return the same output. If these does it might
>> be that your emacs interface escapes the quotes for some reason.
>> i.e. the execution from emacs is analogous to this command line:
>>
>> notmuch search 'id:\"messageid\"'
>>
>
> As they don't return the same output, where do I dig further to find the
> problem?
This we forgot... what does file `which notmuch` report -- just to be
sure...
.. can you put the notmuch binary available somewhere (provided that
the above shows it is .*ELF.* binary).
> -- Erlend
Tomi
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Emacs: notmuch-show-mode failing to actually update tags
2011-10-27 15:01 ` Jameson Graef Rollins
@ 2011-10-27 15:31 ` Thomas Jost
2011-10-28 9:01 ` Erlend Simonsen
1 sibling, 0 replies; 13+ messages in thread
From: Thomas Jost @ 2011-10-27 15:31 UTC (permalink / raw)
To: Jameson Graef Rollins, Erlend Simonsen, notmuch
[-- Attachment #1: Type: text/plain, Size: 1341 bytes --]
On Thu, 27 Oct 2011 08:01:08 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> On Thu, 27 Oct 2011 15:57:00 +0200, Thomas Jost <schnouki@schnouki.net> wrote:
> > Both of these work for me, both with latest master and 0.9-6-g8bb5b62,
> > using Emacs-pretest 24.0.90 (compiled it myself) on Arch Linux... Weird.
>
> Erlend, are you sure you don't have anything else in your emacs
> environment that may be affecting this? What system do you use? How
> was your version of emacs obtained?
Additionnal questions: which version of bash are you using, is it bash
or dash?
> > > <hang for a loooong time>
> >
> > Yep, issue already reported, it's a problem with smtp-dummy. You can fix
> > it by applying the patch from this message:
> > id:"1317660447-27520-14-git-send-email-schnouki@schnouki.net" (or just
> > killall smtp-dummy several times while running the test suite :))
>
> Was this patch not applied? It's part of a series of other patches that
> I think *were* applied. I would be curious to know why this one wasn't.
No. It was part of the series with patches that add emacs+gpg prereqs
and "run emacs in screen" to the test suite, but just after I sent the
series the ML stalled for almost a day... and apparently everyone forgot
about them :)
Regards,
--
Thomas/Schnouki
[-- Attachment #2: Type: application/pgp-signature, Size: 489 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Emacs: notmuch-show-mode failing to actually update tags
2011-10-27 15:01 ` Jameson Graef Rollins
2011-10-27 15:31 ` Thomas Jost
@ 2011-10-28 9:01 ` Erlend Simonsen
1 sibling, 0 replies; 13+ messages in thread
From: Erlend Simonsen @ 2011-10-28 9:01 UTC (permalink / raw)
To: Jameson Graef Rollins, Thomas Jost, notmuch
On Thu, 27 Oct 2011 08:01:08 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> On Thu, 27 Oct 2011 15:57:00 +0200, Thomas Jost <schnouki@schnouki.net> wrote:
> > Both of these work for me, both with latest master and 0.9-6-g8bb5b62,
> > using Emacs-pretest 24.0.90 (compiled it myself) on Arch Linux... Weird.
>
> Erlend, are you sure you don't have anything else in your emacs
> environment that may be affecting this? What system do you use? How
> was your version of emacs obtained?
I found the problem. I was using the Xapian shipped with OpenSuse 11.4,
version 1.0.12. Upgrading to 1.2.7 fixed everything.
Sorry for the confusion.
-- Erlend
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2011-10-28 9:01 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-25 13:25 Emacs: notmuch-show-mode failing to actually update tags Erlend Simonsen
2011-10-25 17:32 ` Jameson Graef Rollins
2011-10-26 7:00 ` Erlend Simonsen
2011-10-26 8:17 ` Tomi Ollila
2011-10-26 9:19 ` Erlend Simonsen
2011-10-27 15:04 ` Tomi Ollila
2011-10-26 15:22 ` Jameson Graef Rollins
2011-10-26 15:23 ` Jameson Graef Rollins
2011-10-27 8:23 ` Erlend Simonsen
2011-10-27 13:57 ` Thomas Jost
2011-10-27 15:01 ` Jameson Graef Rollins
2011-10-27 15:31 ` Thomas Jost
2011-10-28 9:01 ` Erlend Simonsen
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).