unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Cc: David Bremner <bremner@debian.org>
Subject: Re: [PATCH 2/2] notmuch-reply.c: uncrustify
Date: Wed, 11 Jan 2012 17:22:26 +0200	[thread overview]
Message-ID: <yf6lipe4631.fsf@taco2.nixu.fi> (raw)
In-Reply-To: <1326197228-10356-3-git-send-email-david@tethera.net>

On Tue, 10 Jan 2012 08:07:08 -0400, David Bremner <david@tethera.net> wrote:
> From: David Bremner <bremner@debian.org>
> 
> This patch shows the raw result of running uncrustify on notmuch-reply.c.
> The re-indenting of "format_reply" would probably not be desirable.

Nice! It's easy to 'cherry-revert' that part. I wonder is using comments
could be used to preserver formatting in format_reply (and is that is
something wished to be done) i.e. something like:

static const notmuch_show_format_t format_reply = {
    "",
  /* */ "", NULL,
  /* ... */ "", NULL, reply_headers_message_part, ">\n",
  /* ... */ "",
  /* ....... */ NULL,
  /* ....... */ NULL,
  /* ....... */ NULL,
  /* ....... */ reply_part_content,
  /* ....... */ NULL,
  /* ....... */ "",
  /* ... */ "",
  /* */ "", "",


> ---
>  notmuch-reply.c |  160 +++++++++++++++++++++++++-----------------------------
>  1 files changed, 74 insertions(+), 86 deletions(-)
> 
> diff --git a/notmuch-reply.c b/notmuch-reply.c
> index 000f6da..00c9923 100644
> --- a/notmuch-reply.c
> +++ b/notmuch-reply.c
> @@ -32,17 +32,17 @@ reply_part_content (GMimeObject *part);
>  
>  static const notmuch_show_format_t format_reply = {
>      "",
> -	"", NULL,
> -	    "", NULL, reply_headers_message_part, ">\n",
> -	    "",
> -	        NULL,
> -	        NULL,
> -	        NULL,
> -	        reply_part_content,
> -	        NULL,
> -	        "",
> -	    "",
> -	"", "",
> +    "", NULL,
> +    "", NULL, reply_headers_message_part, ">\n",
> +    "",
> +    NULL,
> +    NULL,
> +    NULL,
> +    reply_part_content,
> +    NULL,
> +    "",
> +    "",
> +    "", "",

  reply	other threads:[~2012-01-11 15:22 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-17 15:28 [PATCH] uncrustify.cfg: initial support for notmuch coding style David Bremner
2011-12-17 22:50 ` David Bremner
2011-12-17 23:57   ` Austin Clements
2011-12-18  1:37     ` David Bremner
2012-01-10 12:07 ` David Bremner
2012-01-10 12:07   ` [PATCH 1/2] uncrustify.cfg: initial support for notmuch coding style David Bremner
2012-01-12  4:00     ` Austin Clements
2012-01-17 15:36     ` Tomi Ollila
2012-01-21 21:15     ` David Bremner
2012-01-21 21:35       ` Tomi Ollila
2012-01-10 12:07   ` [PATCH 2/2] notmuch-reply.c: uncrustify David Bremner
2012-01-11 15:22     ` Tomi Ollila [this message]
2012-01-12  3:57     ` Austin Clements
2012-01-12 13:08       ` David Bremner
2012-01-12 13:22         ` Jani Nikula
2012-01-12 13:46         ` Tomi Ollila
2012-01-12 15:26         ` Austin Clements
2012-01-21 19:00           ` David Bremner
2012-01-11 16:03   ` where to put uncrustify... (was: Re: ) Tomi Ollila
2012-01-12  0:15     ` David Bremner
2012-01-17 12:47     ` [PATCH] Start devel directory for developer tools and documentation David Bremner
2012-01-17 23:23       ` Austin Clements
2012-01-18  2:54       ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yf6lipe4631.fsf@taco2.nixu.fi \
    --to=tomi.ollila@iki.fi \
    --cc=bremner@debian.org \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).