From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, Austin Clements <amdragon@MIT.EDU>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] notmuch-reply.c: uncrustify
Date: Thu, 12 Jan 2012 15:46:36 +0200 [thread overview]
Message-ID: <yf6k44xf2yr.fsf@taco2.nixu.fi> (raw)
In-Reply-To: <87r4z56pbx.fsf@zancas.localnet>
On Thu, 12 Jan 2012 09:08:18 -0400, David Bremner <david@tethera.net> wrote:
>
> > All of the other format fixes look very reasonable to me. I think you
> > managed to find one of the least canonical source files in the tree.
> > Was that intentional?
>
> Yes, I expect there would be less changes elsewhere. Although the
> changes might be more controversial, I guess.
>
> The corresponding diff for notmuch-search.c follows
>
> diff --git a/notmuch-search.c b/notmuch-search.c
[ ... ]
> @@ -122,7 +122,7 @@ sanitize_string (const void *ctx, const char *str)
> loop = out = talloc_strdup (ctx, str);
>
> for (; *loop; loop++) {
> - if ((unsigned char)(*loop) < 32)
> + if ((unsigned char) (*loop) < 32)
> *loop = '?';
Should (cast) be concatenated without space to the castee
> }
> return out;
> @@ -160,7 +160,7 @@ format_item_id_json (const void *ctx,
> printf ("%s", json_quote_str (ctx_quote, item_id));
>
> talloc_free (ctx_quote);
> -
> +
Whee, whitespace-cleanup !
> }
>
[ ... ]
Tomi
next prev parent reply other threads:[~2012-01-12 13:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-17 15:28 [PATCH] uncrustify.cfg: initial support for notmuch coding style David Bremner
2011-12-17 22:50 ` David Bremner
2011-12-17 23:57 ` Austin Clements
2011-12-18 1:37 ` David Bremner
2012-01-10 12:07 ` David Bremner
2012-01-10 12:07 ` [PATCH 1/2] uncrustify.cfg: initial support for notmuch coding style David Bremner
2012-01-12 4:00 ` Austin Clements
2012-01-17 15:36 ` Tomi Ollila
2012-01-21 21:15 ` David Bremner
2012-01-21 21:35 ` Tomi Ollila
2012-01-10 12:07 ` [PATCH 2/2] notmuch-reply.c: uncrustify David Bremner
2012-01-11 15:22 ` Tomi Ollila
2012-01-12 3:57 ` Austin Clements
2012-01-12 13:08 ` David Bremner
2012-01-12 13:22 ` Jani Nikula
2012-01-12 13:46 ` Tomi Ollila [this message]
2012-01-12 15:26 ` Austin Clements
2012-01-21 19:00 ` David Bremner
2012-01-11 16:03 ` where to put uncrustify... (was: Re: ) Tomi Ollila
2012-01-12 0:15 ` David Bremner
2012-01-17 12:47 ` [PATCH] Start devel directory for developer tools and documentation David Bremner
2012-01-17 23:23 ` Austin Clements
2012-01-18 2:54 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yf6k44xf2yr.fsf@taco2.nixu.fi \
--to=tomi.ollila@iki.fi \
--cc=amdragon@MIT.EDU \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).