From: Tomi Ollila <tomi.ollila@nixu.com>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 4/4] test: fix error messages for missing binary dependencies
Date: Tue, 29 Nov 2011 16:48:55 +0200 [thread overview]
Message-ID: <yf6d3cbm1bc.fsf@taco2.nixu.fi> (raw)
In-Reply-To: <1322520067-15227-5-git-send-email-dmitry.kurochkin@gmail.com>
LGTM
On Tue, 29 Nov 2011 02:41:07 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> The fake missing binary functions check if the binary has already be
> added to the diagnostic message to avoid duplicates. Unfortunately,
> this check was buggy because the message string does not have the
> trailing space.
> ---
> test/test-lib.sh | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/test/test-lib.sh b/test/test-lib.sh
> index 2861d88..a975957 100644
> --- a/test/test-lib.sh
> +++ b/test/test-lib.sh
> @@ -556,7 +556,7 @@ test_declare_external_prereq () {
> hash $binary 2>/dev/null || eval "
> test_missing_external_prereq_${binary}_=t
> $binary () {
> - echo -n \"\$test_subtest_missing_external_prereqs_\" | grep -qe \" $name \" ||
> + echo -n \"\$test_subtest_missing_external_prereqs_ \" | grep -qe \" $name \" ||
> test_subtest_missing_external_prereqs_=\"\$test_subtest_missing_external_prereqs_ $name\"
> false
> }"
> --
> 1.7.7.3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
>
--
Tomi Ollila !! tomi.ollila@nixu.fi !! +358 400 888 366
Nixu Oy !! http://www.nixu.fi/ !! Keilaranta 15, FI-02150 Espoo, Finland
next prev parent reply other threads:[~2011-11-29 14:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 22:41 [PATCH 0/4] fix a bunch of bugs in recently added binary dependencies Dmitry Kurochkin
2011-11-28 22:41 ` [PATCH 1/4] test: fix test_require_external_prereq() Dmitry Kurochkin
2011-11-28 22:41 ` [PATCH 2/4] test: add missing escape backslash in test_declare_external_prereq() Dmitry Kurochkin
2011-11-28 22:41 ` [PATCH 3/4] test: fix spurious output from missing external binaries functions Dmitry Kurochkin
2011-11-28 22:41 ` [PATCH 4/4] test: fix error messages for missing binary dependencies Dmitry Kurochkin
2011-11-29 14:48 ` Tomi Ollila [this message]
2011-12-01 1:34 ` [PATCH 0/4] fix a bunch of bugs in recently added " David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yf6d3cbm1bc.fsf@taco2.nixu.fi \
--to=tomi.ollila@nixu.com \
--cc=dmitry.kurochkin@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).