From: Tomi Ollila <tomi.ollila@iki.fi>
To: notmuch@notmuchmail.org
Subject: [PATCH] remove GCC visibility pragmas
Date: Mon, 31 Oct 2011 14:01:28 +0200 [thread overview]
Message-ID: <yf67h3lgyjr.fsf@taco2.nixu.fi> (raw)
libnotmuch.so.* linking fail on some environments. According to
David Bremner on irc:
"We jump through hoops with the linker script (notmuch.sym) so
the pragmas are not needed. And they are a little bizarre in a
library anyway..."
---
util/xutil.h | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/util/xutil.h b/util/xutil.h
index 9299256..b84e0e2 100644
--- a/util/xutil.h
+++ b/util/xutil.h
@@ -25,8 +25,6 @@
#include <sys/types.h>
#include <regex.h>
-#pragma GCC visibility push(hidden)
-
/* xutil.c */
void *
xcalloc (size_t nmemb, size_t size);
@@ -51,6 +49,4 @@ int
xregexec (const regex_t *preg, const char *string,
size_t nmatch, regmatch_t pmatch[], int eflags);
-#pragma GCC visibility pop
-
#endif
--
1.7.6.2
next reply other threads:[~2011-10-31 12:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 12:01 Tomi Ollila [this message]
2011-10-31 12:07 ` [PATCH] remove GCC visibility pragmas David Bremner
2011-10-31 12:19 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yf67h3lgyjr.fsf@taco2.nixu.fi \
--to=tomi.ollila@iki.fi \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).