From: Tomi Ollila <tomi.ollila@iki.fi>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] test: add functions to count how much times notmuch was called
Date: Wed, 30 Nov 2011 13:53:24 +0200 [thread overview]
Message-ID: <yf662i1n7wr.fsf@taco2.nixu.fi> (raw)
In-Reply-To: <87aa7evdy8.fsf@gmail.com>
On Wed, 30 Nov 2011 01:03:27 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> Hi Tomi.
>
> On Tue, 29 Nov 2011 14:58:00 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> > Hi Dmitry.
[ ... ]
> >
> > The (posix) shell command language defines 'Arithmetic Expansion' in
> >
> > http://pubs.opengroup.org/onlinepubs/007908799/xcu/chap2.html#tag_001_006_004
> >
> > I.e. using format $(( expression )) makes shell doing the arithetic itself
> > instead of forking a process (or two!) to do so.
> >
>
> I though expr was a builtin. Now I agree that it is better to replace
> it with $(()), even though I still prefer the expr syntax.
Actually, I thought also that expr was a builtin. That makes the resolution
'forks subshell to execute builtin expr' below wrong. If it were a builtin
then bash would also fork only once (to get details right). I re-tested
with zsh using 'builtin pwd' and '/bin/pwd' instead of 'expr' -- only one fork
in each case. So, those who examined my tests with deep interest also note
this correction.
> > Normally in this case it is not so big deal (and still it isn't, but...)
> > In this particular case the shell wrapper counting notmuch launches and
> > exec'ing it the wrapper could do this without fork(2)ing a single time
> > (i.e. keep the process count unchanged compared to execing notmuch
> > directly)
> >
> > Anyway, many opinions; as far as it works I'm fine with it :)
> >
> > Now that you feel relaxed, check the results of some further
> > experimentation ;) :
> >
> > excerpt from man strace:
> >
> > -ff If the -o filename option is in effect, each processes
> > trace is written to filename.pid where pid is the
> > numeric process id of each process.
> >
> > Executing rm -f forked.*; strace -ff -o forked bash -c 'echo $(( 5 + 5 ))'
> >
> > will output '10' and create just one 'forked.<pid>' file
> >
> > Executing rm -f forked.*; strace -ff -o forked bash -c 'echo $(expr 5 + 5)'
> >
> > output 10 as expected, but there is now *3* forked.<pid> files !
> >
> > bash does not optmize; it forks subshell to execute $(...) and then
> > there just works as usual (forks subshell to execute builtin expr))
> >
> > Executing rm -f forked.*; strace -ff -o forked bash -c 'echo $(exec expr 5 + 5)'
> >
> > (the added 'exec' takes off one fork -- just 2 forked.<pid> files appear).
> >
> > I did the same tests using dash, ksh & zsh on linux system, and every one
> > of these managed to optimize one fork out in the above 3 fork case.
> >
>
> Thanks for details.
>
> Regards,
> Dmitry
>
> >
> > Tomi
Tomi
next prev parent reply other threads:[~2011-11-30 11:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-26 1:44 [PATCH 1/3] test: add functions to count how much times notmuch was called Dmitry Kurochkin
2011-11-26 1:44 ` [PATCH 2/3] test: check that Emacs UI does not call notmuch for non-inlinable parts Dmitry Kurochkin
2011-11-28 2:46 ` Austin Clements
2011-11-26 1:44 ` [PATCH 3/3] emacs: do not call notmuch show " Dmitry Kurochkin
2011-11-28 2:54 ` Austin Clements
2011-11-28 2:44 ` [PATCH 1/3] test: add functions to count how much times notmuch was called Austin Clements
2011-11-28 3:09 ` Dmitry Kurochkin
2011-11-28 3:28 ` [PATCH 0/3] emacs: do not call notmuch show for non-inlinable parts Dmitry Kurochkin
2011-11-28 3:28 ` [PATCH 1/3] test: add functions to count how much times notmuch was called Dmitry Kurochkin
2011-11-28 20:42 ` Tomi Ollila
2011-11-28 21:26 ` Dmitry Kurochkin
2011-11-29 12:58 ` Tomi Ollila
2011-11-29 21:03 ` Dmitry Kurochkin
2011-11-30 11:53 ` Tomi Ollila [this message]
2011-11-29 14:40 ` Jameson Graef Rollins
2011-11-28 3:28 ` [PATCH 2/3] test: check that Emacs UI does not call notmuch for non-inlinable parts Dmitry Kurochkin
2011-11-28 3:28 ` [PATCH 3/3] emacs: do not call notmuch show " Dmitry Kurochkin
2011-11-28 3:39 ` [PATCH 0/3] " Austin Clements
2011-11-28 14:24 ` Jameson Graef Rollins
2011-11-28 21:13 ` [PATCH v3 " Dmitry Kurochkin
2011-11-28 21:13 ` [PATCH v3 1/3] test: add functions to count how much times notmuch was called Dmitry Kurochkin
2011-11-28 21:13 ` [PATCH v3 2/3] test: check that Emacs UI does not call notmuch for non-inlinable parts Dmitry Kurochkin
2011-11-28 21:13 ` [PATCH v3 3/3] emacs: do not call notmuch show " Dmitry Kurochkin
2011-11-29 21:19 ` [PATCH v4 0/3] " Dmitry Kurochkin
2011-11-29 21:19 ` [PATCH v4 1/3] test: add functions to count how much times notmuch was called Dmitry Kurochkin
2011-11-30 11:57 ` Tomi Ollila
2011-11-29 21:19 ` [PATCH v4 2/3] test: check that Emacs UI does not call notmuch for non-inlinable parts Dmitry Kurochkin
2011-11-29 21:19 ` [PATCH v4 3/3] emacs: do not call notmuch show " Dmitry Kurochkin
2011-12-07 15:11 ` [PATCH v4 0/3] " Dmitry Kurochkin
2011-12-08 1:00 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yf662i1n7wr.fsf@taco2.nixu.fi \
--to=tomi.ollila@iki.fi \
--cc=dmitry.kurochkin@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).