unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Olivier Berger <olivier.berger@it-sudparis.eu>,
	David Bremner <david@tethera.net>,
	notmuch@notmuchmail.org
Cc: 652359@bugs.debian.org
Subject: Re: notmuch-emacs won't display correctly quoted-printable iso-8859-1 mails
Date: Sun, 18 Dec 2011 18:08:55 +0200	[thread overview]
Message-ID: <yf662hdkgko.fsf@taco2.nixu.fi> (raw)
In-Reply-To: <8762heexsp.fsf@inf-8657.int-evry.fr>

On Sun, 18 Dec 2011 15:53:26 +0100, Olivier Berger <olivier.berger@it-sudparis.eu> wrote:
> On Sun, 18 Dec 2011 10:11:37 -0400, David Bremner <david@tethera.net> wrote:
> > Hi Olivier;
> > 
> > Can you try the following patch? If you apply it to git, you can use
> > "make debian-snapshot" to build new packages (assuming you have the
> > pre-reqs).
> > 
> > Or just patch the notmuch-query.el installed by notmuch-emacs and reload
> > it.
> > 
> 
> I did that over notmuch-emacs 0.10.2-1 Debian package's version of
> notmuch-query.el, but that doesn't seem change anything, unfortunately :
> the modeline still is '-1:%*-' for the notmuch-show buffer, after
> hitting RET over a message's line in a search result list :-(

I tested the same on terminal configured for latin9 and LC_ALL=fi_FI@euro
and the change worked for me.

The buffer modeline is not supposed to change -- the change makes emacs
read incoming data encoded in utf-8 format (notmuch outputs everything
in utf-8). Before the change emacs expected (in your case) input data being
in latin1 format ("guessed" from your locale), but as input was in utf-8 the
conversion to emacs internal format went wrong.

When emacs displays something (buffer content, that is) it converts the
internal format to the encoding emacs window is using. 

So, my guess is you did something wrong when trying David's patch and
you did not get the change evaluated.

This what I did:

I opened emacs/notmuch-query.el to another emacs window while 
notmuch-hello open in another window.

Then I added line (coding-system-for-read 'utf-8) in line 35:

  (let  ((args '("show" "--format=json"))
         (json-object-type 'plist)
         (json-array-type 'list)
         (coding-system-for-read 'utf-8)
         (json-false 'nil))

then moved cursor to the end of line 44 which shows: (json-read)))))
(last line of that function) and entered c-x c-e
(eval-last-sexp) -- that re-evaluates the function definition.

And, as said, after that change my emails render correctly on
latin1 -terminal (as opposed those did not render correctly before)

> Hope this helps.

I hope that I'm right in my guess so we get forward easier... :)

> 
> Best regards,
> -- 
> Olivier BERGER 

Tomi

  reply	other threads:[~2011-12-18 16:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20111216160104.24920.82593.reportbug@inf-8657.int-evry.fr>
2011-12-16 16:28 ` notmuch-emacs won't display correctly quoted-printable iso-8859-1 mails Olivier Berger
2011-12-18 14:11   ` David Bremner
2011-12-18 14:53     ` Olivier Berger
2011-12-18 16:08       ` Tomi Ollila [this message]
2011-12-18 21:42         ` Olivier Berger
2011-12-18 21:55       ` Bug#652359: " David Bremner
2011-12-18 22:22         ` Olivier Berger
2011-12-19  0:03     ` Bug#652359: notmuch-emacs: Won't " David Bremner
2011-12-19 10:25       ` Olivier Berger
2011-12-19 10:34         ` Olivier Berger
2011-12-19 10:53           ` SOLVED - Was: " Olivier Berger
2011-12-19 11:15             ` Tomi Ollila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yf662hdkgko.fsf@taco2.nixu.fi \
    --to=tomi.ollila@iki.fi \
    --cc=652359@bugs.debian.org \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    --cc=olivier.berger@it-sudparis.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).