unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: michaeljgruber+grubix+git@gmail.com, notmuch@notmuchmail.org
Cc: Michael J Gruber <git@grubix.eu>
Subject: Re: [PATCH] test: increase cffi timeout
Date: Mon, 15 Aug 2022 23:56:40 +0300	[thread overview]
Message-ID: <y3ddule.hrdrxy-too@iki.fi> (raw)
In-Reply-To: <a308aa5dd9adfa4c534da380444991c33a6c7d0d.1660490052.git.git@grubix.eu>

On Sun, Aug 14 2022, michaeljgruber wrote:

> From: Michael J Gruber <git@grubix.eu>
>
> By default, the test suite uses 2min for other tests and 5s for cffi
> tests. Sporadically, this leads to test failures caused by the timeout
> on slower or loaded test infrastructure (as seen on ppc64le in Fedora's
> infrastructure during branch time).
>
> Increase the cffi timeout to the same 2m=120s.
>
> Signed-off-by: Michael J Gruber <git@grubix.eu>
> ---
> It's the first time I encountered this on Fedora's infrastructure during
> a test build. In any case, having the timeouts similar may make sense in
> general, unless we typically run into them in normal (local) use.
>
>  bindings/python-cffi/tests/conftest.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bindings/python-cffi/tests/conftest.py b/bindings/python-cffi/tests/conftest.py
> index 6835fd30..fe90c787 100644
> --- a/bindings/python-cffi/tests/conftest.py
> +++ b/bindings/python-cffi/tests/conftest.py
> @@ -43,7 +43,7 @@ def notmuch(maildir):
>          env = os.environ.copy()
>          env['NOTMUCH_CONFIG'] = str(cfg_fname)
>          proc = subprocess.run(cmd,
> -                              timeout=5,
> +                              timeout=120,

LGTM.

Tomi

>                                env=env)
>          proc.check_returncode()
>      return run
> -- 
> 2.37.2.596.g72ccb331cf

  reply	other threads:[~2022-08-15 20:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-14 15:22 [PATCH] test: increase cffi timeout michaeljgruber+grubix+git
2022-08-15 20:56 ` Tomi Ollila [this message]
2022-08-16  7:37 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=y3ddule.hrdrxy-too@iki.fi \
    --to=tomi.ollila@iki.fi \
    --cc=git@grubix.eu \
    --cc=michaeljgruber+grubix+git@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).