From: Tomi Ollila <tomi.ollila@iki.fi>
To: "Antoine Beaupré" <anarcat@debian.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs/show: use read-shell-command instead of read-string
Date: Wed, 31 Aug 2022 20:20:55 +0300 [thread overview]
Message-ID: <y3cgwo4.mlmj78-too@iki.fi> (raw)
In-Reply-To: <20220830141745.2139035-1-anarcat@debian.org>
On Tue, Aug 30 2022, Antoine Beaupré wrote:
> This enables auto-completion of commands, something which plain
> read-string does not do. It's otherwise a drop-in
> replacement. According to `C-h f`, read-shell-command was introduced
> in Emacs 23.1 or earlier.
LGTM.
Tomi
> ---
> emacs/notmuch-show.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 2dcef981..ec998ede 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -2192,7 +2192,7 @@ message."
> (interactive (let ((query-string (if current-prefix-arg
> "Pipe all open messages to command: "
> "Pipe message to command: ")))
> - (list current-prefix-arg (read-string query-string))))
> + (list current-prefix-arg (read-shell-command query-string))))
> (let (shell-command)
> (if entire-thread
> (setq shell-command
> --
> 2.30.2
>
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org\r
next prev parent reply other threads:[~2022-08-31 17:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 14:17 [PATCH] emacs/show: use read-shell-command instead of read-string Antoine Beaupré
2022-08-31 17:20 ` Tomi Ollila [this message]
2022-09-03 11:22 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=y3cgwo4.mlmj78-too@iki.fi \
--to=tomi.ollila@iki.fi \
--cc=anarcat@debian.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).