From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MI+INRjlqGMfLQEAbAwnHQ (envelope-from ) for ; Mon, 26 Dec 2022 01:04:40 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id uK9xNRjlqGPxTAAAauVa8A (envelope-from ) for ; Mon, 26 Dec 2022 01:04:40 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 894FE1AE05 for ; Mon, 26 Dec 2022 01:04:40 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 4AE995F9AD; Mon, 26 Dec 2022 00:04:35 +0000 (UTC) Received: from meesny.iki.fi (meesny.iki.fi [195.140.195.201]) by mail.notmuchmail.org (Postfix) with ESMTPS id CB8095F383 for ; Mon, 26 Dec 2022 00:04:31 +0000 (UTC) Received: from c53 (gw1.nor.fi [185.218.193.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: too) by meesny.iki.fi (Postfix) with ESMTPSA id 21BF82031D; Mon, 26 Dec 2022 02:04:29 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1672013069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AJmFqFTcFwU2o66eVmYgXgrafNQDrn3AmlijvxcA+LE=; b=I+8dw1Ru0YsfEzBiVFkgw/IfMCJotBXinggtCRNbJNojBMVhFsEVEsi9LRvNm/ZPQcHAJw oDAXrJ6tn/JzOQWmuNHGiEoHh/aIXX0DtcrkGMZ47UzpcbwVGmmDpAYnIqEqXEeBnwNm+v /KzOk/7a8cDSdHRbqq1KQBEeIhqNMOM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1672013069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AJmFqFTcFwU2o66eVmYgXgrafNQDrn3AmlijvxcA+LE=; b=xd9Jt1WmaQDUyvP92q2lc8epLlOLXrBoozl1QX4rKemNNosPO/ye6NXtwlFZ9VqyOV3kjf VgHj7B145FXar1MiuUCjyQIHcUheJWTAyVKyw3ou09mje+8rHMVggW3KEBbZuymeDNlf0t A6bZZnZN3xM2uaCb10l+QO/UF78dgBc= ARC-Seal: i=1; s=meesny; d=iki.fi; t=1672013069; a=rsa-sha256; cv=none; b=PrYeU1nqFfQa5h6BdTXF2SnVHQSoCBdmJNbFpCHIW6wVTefDWhhm9R1O4J3eJX+ZDxMAbH nVIE6Swd9Z7kUKlxFEjMzlst/g1XEwpJwwVRbww/vLTzoJpD5SpIyq63v9E3jnzetwLTAU E4ozmB5p2DfaLF4Haq29u9QYAMKWZn8= ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi From: Tomi Ollila To: David Bremner , Thomas Schneider , notmuch@notmuchmail.org Subject: Re: [PATCH 1/3] lib/database: propagate status code from _notmuch_message_delete In-Reply-To: <20221204022857.1551514-2-david@tethera.net> References: <20221204022857.1551514-1-david@tethera.net> <20221204022857.1551514-2-david@tethera.net> User-Agent: Notmuch/0.37+27~gff8ef59 (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 Message-ID-Hash: V74O5725TKWXAQSZQQZVLQX6NNQ6OIPO X-Message-ID-Hash: V74O5725TKWXAQSZQQZVLQX6NNQ6OIPO X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Country: DE X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1672013080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=/PAIEh1bZF0jcQI9lhImElgXgqbeCSePPBZQ64/TrAY=; b=dgyPZN5i8v2hQ8iqzYycq51sPlPaQ50wiXiYP0Gj1o5rKNTN4jddQSzHMTp7fczJAt87um 5zx9Bd2vcL4WsypaQM/MHpbjI58Hw3F+HCCA9wasdRWsjH8wX8JF8mTIYgUZxtq4FtmvRS XVfUjHDzfLTrB+jV+Wz/GmYK3fL0X2459gOWbLGqdrQRPxa3eFau00YHm6On7OIeSSGgmL VQM07ukhvnsde/fLYGaLAD1RbtOd1gyoE1sfejAoJvK+/a1Y/suCDoN1LGTbFUz8Fqvm16 DbtYEN5h4s1f7XAcOvPEKTn8j1zterazY5+ltZGZTyozEu8GlEI6gnaF9oUgkg== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=meesny header.b=I+8dw1Ru; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=none ARC-Seal: i=2; s=key1; d=yhetil.org; t=1672013080; a=rsa-sha256; cv=fail; b=Rif6G64RkBskyw7Vkr3OqPTYAN/R0iJb1KuJh+a6wJ7sUSREhTwI+J7SbaI7RVPyfWUDYD JePhBi6CZQ2qm+Esbdj53VJeo1To0lpAsQZyFLnyiX9AzMSIDqlKbzjCGzmpVNh2FukeHT Zw7KaWpqtwOtth4t4Jdjue4HYSrg8f6h3JH19YGDkFf0U2IDOvZ9Y3DobF6J7HZl1O3gp9 5lyfTyyZQRkF0u22tVuHZaGpL9Wbai+QTQPJiGokG8GH1WbjAWwqN1nUZY8fDQbM6prE7K hsWkG4psDtnE5RdJLZtdHyhurrVzBfpk2ARjRr37NS3eesa4w+Mxif8diUkiBg== X-Spam-Score: 3.43 X-Migadu-Queue-Id: 894FE1AE05 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=meesny header.b=I+8dw1Ru; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=none X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: 3.43 X-TUID: A5h4VoLRtmb4 On Sat, Dec 03 2022, David Bremner wrote: > _notmuch_message_delete can return (at least) > NOTMUCH_STATUS_XAPIAN_EXCEPTION, which we should not ignore. Series LGTM Tomi > --- > lib/database.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/database.cc b/lib/database.cc > index c05d70d3..d1e5f1af 100644 > --- a/lib/database.cc > +++ b/lib/database.cc > @@ -1456,7 +1456,7 @@ notmuch_database_remove_message (notmuch_database_t *notmuch, > if (status == NOTMUCH_STATUS_SUCCESS && message) { > status = _notmuch_message_remove_filename (message, filename); > if (status == NOTMUCH_STATUS_SUCCESS) > - _notmuch_message_delete (message); > + status = _notmuch_message_delete (message); > else if (status == NOTMUCH_STATUS_DUPLICATE_MESSAGE_ID) > _notmuch_message_sync (message); > > -- > 2.35.2 > > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org