From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id MPikIyJ862RmzQAA9RJhRA:P1 (envelope-from ) for ; Sun, 27 Aug 2023 18:38:58 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id MPikIyJ862RmzQAA9RJhRA (envelope-from ) for ; Sun, 27 Aug 2023 18:38:58 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AC4A841184 for ; Sun, 27 Aug 2023 18:38:57 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=meesny header.b=FUG0XRx+; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693154338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=t7eLHRqqXtWSost53If9D2d3xvFqds2xJwxNTCV/0h4=; b=MzDKWhZlhuEbX3yIX9Wy/IncCQ6rSwUKiJ3QcJozK/R2oh+QGMfE0l22OUG4H1TcrCd+Ah KbUFdnabzvioKHXHdpdi9KvPv6bOdr0UzFOZBgESHjffe+9SrkThhq++1ZaTxJy4gvhd/6 9LcKrQKtr6fQ/2cQ2wJUzfER3FheGds5tvMCOwmlMDWCLiF4g/Ayhz7TrRUsr2fzD6v5mp hEIYVa+LuwYKna0WHdzMz1UzndWznLcxWCf9ccdYcHW7MtnipHbohHgE4M41308EoISYS/ s9HYAQUadqa/0lN1a7NTzZOOYPQawWoVjXMW0hO/Jh9DHYvraenQCq/IQGpRJg== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1693154338; a=rsa-sha256; cv=fail; b=fl2RKuOXNlB7CDF3r3S+fvvg9zrZjJ+8gAekOMVQ28MuDzs2kgsAJnhejLMCItacHWMl0T toU6FiVBrIn6DJgvNZYkEwlQpste47mqN+xRaT1QSnU3dFxyRTrcYiYUmsijLJ7sF5tFTe 4Kzuca2XQu22L4dM0/ZIqy6hoNOx7Uac/F/BOmRs9aIdImT6o/7mnz8S5ynaD4m91A+B36 lsaKpoGhLnRbfIVpbXgzIqgWzE4UPTTIpWdnw0oksEr2PLgOKT4V8JkbZsxjrX5R65rRQO gTNE2r1jkfOfxJ/e+IiCnJRP+v5Sy+jGPVlMxlnYYpWT73U2ErIb2oA+QjT5SA== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=meesny header.b=FUG0XRx+; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}") Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 844525E54B; Sun, 27 Aug 2023 16:38:54 +0000 (UTC) Received: from meesny.iki.fi (meesny.iki.fi [195.140.195.201]) by mail.notmuchmail.org (Postfix) with ESMTPS id AC42F5DD59 for ; Sun, 27 Aug 2023 16:38:51 +0000 (UTC) Received: from c53 (gw1.nor.fi [185.218.193.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: too) by meesny.iki.fi (Postfix) with ESMTPSA id 4RYfX92P3czyd3; Sun, 27 Aug 2023 19:38:49 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1693154330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zmzSvokwlX1CMVZpJoQJd8uUq8uNqjD+UOpNlSWo/6w=; b=FUG0XRx+cEbp0g0DXqnj6VWZ8YMIO2xq+IFNuwcuB+YiB8Cd6NW+FKmUvxrL/HTsp1fH/a PrveiA33pqNQPcbH723lQhhCCMN82czPRIj3OsLrZ0BaL357D/h9JJr0MLCJqPO50I9Egz z/8RFWh2SsUiFqzlEPODiWVoNSBIVJc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1693154330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zmzSvokwlX1CMVZpJoQJd8uUq8uNqjD+UOpNlSWo/6w=; b=YHXlIssg2qI1XhIOHiHxibzP9Gu/lv/cCYgv7Gs+QA6h/An2ghC6fQAtlolz3gEfdctP6E Hm0XlhlHalKFHlr/DVY9ttY9bsaqEbdWnXltsWJqG0og3CYxenE21nvgoNWv479LIEGoyi Fi211ecMuiai4k3yMZOvGWQcML9gTwk= ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=meesny; d=iki.fi; t=1693154330; a=rsa-sha256; cv=none; b=eHIyY0aUxDuFA7n52IMlkYkoB6DMR1rqd1AMj64ZT3n36ntDBlc1Uf6DSr8ztayf1kkt2K 32EpV1FZ6yOWhE0D6jcAX91kTFbDB+fwEqXfAdWrVDc7YERMxH9sAnMMNQ81PQ/EHriRYm ZYB1TDhZEY0F+hrQigmi6U5YYbkKSgE= From: Tomi Ollila To: michaeljgruber+grubix+git@gmail.com, notmuch@notmuchmail.org Subject: Re: [PATCH] compat: probe for strcasestr more thoroughly In-Reply-To: References: User-Agent: Notmuch/0.37+27~gff8ef59 (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 Message-ID-Hash: PJ3SFQQDZJWMKV3QFJKD7N7HOS3NBIMQ X-Message-ID-Hash: PJ3SFQQDZJWMKV3QFJKD7N7HOS3NBIMQ X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Michael J Gruber , Thomas Schneider , Florian Weimer X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE X-Migadu-Spam-Score: -1.96 X-Spam-Score: -1.96 X-Migadu-Queue-Id: AC4A841184 X-Migadu-Scanner: mx1.migadu.com X-TUID: /y8AogxHavV/ On Sat, Aug 26 2023, michaeljgruber wrote: > From: Michael J Gruber > > Depending on compiler (gcc, g++, clang) and standard options (c99, c11), > string.h may or may not include strings.h, leading to possibly missing > or conflicting declarations of strcasestr. > > Include both so that both detection and compilation phases use the same > (possibly optimised) implementations. > > Suggested-by: Thomas Schneider > Suggested-by: Florian Weimer > Suggested-by: Tomi Ollila > --- LGTM :D Tomi > This is related to the discussion here: > https://nmbug.notmuchmail.org/nmweb/show/20221202191908.848227-1-qsx%40chaotikum.eu> > > We've been carrying FW's version of the patch in Fedora since January. > The one here is TO's version of TS's original and tested in Fedora. > > compat/have_strcasestr.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/compat/have_strcasestr.c b/compat/have_strcasestr.c > index 3cd1838d..8e004572 100644 > --- a/compat/have_strcasestr.c > +++ b/compat/have_strcasestr.c > @@ -1,5 +1,6 @@ > #define _GNU_SOURCE > -#include > +#include /* strcasecmp() in POSIX */ > +#include /* strcasecmp() in *BSD */ > > int > main () > -- > 2.42.0.290.gfcfb41f205