From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:5f26::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id cKHQGB/9dmUOEQEAkFu2QA (envelope-from ) for ; Mon, 11 Dec 2023 13:14:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id uCgJFh/9dmWRRQAAqHPOHw (envelope-from ) for ; Mon, 11 Dec 2023 13:14:23 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=meesny header.b=tAO508UH; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1702296863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=vXPyY8iwBHHSNV7+bgrY8/wIxT3vsobyLU8QNN8x6qQ=; b=Cp55zPD2kPck+fCbAZmCrYcyRRASlvZPNXQpjE59tJ+Ogq0ybK0205K8obzwxIfhh3KG9W +Jongxe6H5z846mlpdpOGushzG+OQa62Weng4kURHp0Ira4SrS24IWr7aWxa3I9IPA82W1 1EyTvTikgnXZN6+lzB13BNqLXe+52wRHRTsyNDBQe1zof6U1hIStYCu/QeUX2Xr6v00UAm C+LVVWMga6q/GNetyruCcEi7L0jm8BdB3CmCvt2eMg0DaLTNC6QG7oT6aVS5hQfaDGiotr d7zDbGJ8r52PpBPj39loGLeFpa92gTaTgAX1D/AP9fZteIrfpSe28lpZBzti2Q== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=meesny header.b=tAO508UH; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}") ARC-Seal: i=2; s=key1; d=yhetil.org; t=1702296863; a=rsa-sha256; cv=fail; b=Rh8rGvT2b+RxyuXZSj/9Re2hYc6wd81Z74hkhHdFQauF6KnQEzbkQNVN72djG+hSKeqplG +Yb46Y3Yf6SyLqr9yMJDvuZyxu4fGN2SfiEtKirq+EtDuX4NJokDELBpOpGo7IB+c4/0RG 4CA1RNN3jxGdpbxFXPMvv5W6JHOEIb2378T80zNAW/vQ4F7oXzz/fsNmgUhhQ+eOgAHerf 0LxJL1iWuV44/DQwAZk2GKTUdjG+cp+59SY6C6/YDp+Vyjcz86mRD7WmmqhELG6PW0sRtf j40eeLpCtD/tKbtuVh/aBUHrNtYs2kwzki6ej9uVVUtlGUM/H/v07LU3N3YPbg== Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0C0E9672F3 for ; Mon, 11 Dec 2023 13:14:23 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id C68045E523; Mon, 11 Dec 2023 12:14:18 +0000 (UTC) Received: from meesny.iki.fi (meesny.iki.fi [IPv6:2001:67c:2b0:1c1::201]) by mail.notmuchmail.org (Postfix) with ESMTPS id 646835E51F for ; Mon, 11 Dec 2023 12:14:15 +0000 (UTC) Received: from c53 (gw1.nor.fi [185.218.193.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: too) by meesny.iki.fi (Postfix) with ESMTPSA id 4Spgdy0S2jzyPB; Mon, 11 Dec 2023 14:14:13 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1702296854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DUPDShbxlMwyXcgl+oaImBRmG4SR4rPn2hlHMsq9CQk=; b=tAO508UH74Z7GDStBqxO8EjXlenhE+XAlXNRJraqarszJeLqrvTVdPQMQz/g7nPi254w5a 6wR1Pmnj1vxN4yQpdcjqh+9Af85fmEKszlZSpY6ixmrTu88nCE8G+qZKpgj38DbgXB3j9c V6zZZZbuWO7n/diqhpJ9P7DepxTUsME= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1702296854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DUPDShbxlMwyXcgl+oaImBRmG4SR4rPn2hlHMsq9CQk=; b=cwj3ROS+zQTX8tkPVickIGwmpchVmWdbfyrhaacTD0M02D47lZ4fC1WqpDjoFBRKxixMRb 3YcZ3fJgxaj4IQzaQTkl1/XWJH7et6RaZpPO+f3aLFXtt/Q8aoYgl7lfjMtlbGxDKoIGBK naEHUIt4DY1aSYTDDdtTycQFvmo5r20= ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=meesny; d=iki.fi; t=1702296854; a=rsa-sha256; cv=none; b=GRB4OzOaFwQ5kzL/ThFFhouwWvSmJYECrHZiWZ0WfGQl1l8pq6MU7WILlOFqmC1bmhwpqf g3K73zjnq9b8PEPt68b5zdxnjuO8xBtj/zQhHxtrTkX2d2xiM3bhRrUIVe0i8O65Sm6V5d Y22f1g3K1X9Qvy8Nt6nSz8uChLQhaS0= From: Tomi Ollila To: David Bremner , Sandra Snan , notmuch@notmuchmail.org Subject: Re: [PATCH] Add hook inside notmuch-mua-reply In-Reply-To: <87msuhaqub.fsf@tethera.net> References: <20231210224024.1414315-1-sandra.snan@idiomdrottning.org> <87msuhaqub.fsf@tethera.net> User-Agent: Notmuch/0.38+5~gf38f4f8 (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 Message-ID-Hash: 63LNYBKSBRXVNQN6MNXTZL366F5OBCZW X-Message-ID-Hash: 63LNYBKSBRXVNQN6MNXTZL366F5OBCZW X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Country: DE X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: 0.69 X-Spam-Score: 0.69 X-Migadu-Queue-Id: 0C0E9672F3 X-TUID: 7cWMZ6fG15AE On Mon, Dec 11 2023, David Bremner wrote: > Sandra Snan writes: > > >> +(defvar in-notmuch-mua-reply-functions nil >> + "Functions to run after `notmuch-reply' was called successfully >> +without erroring. The functions get the message-id as a string >> +argument.") >> + > > Overall this looks reasonable to me, but I'm not sure about the > name. Since emacs doesn't have any namespace facility, I think that any > globals we define should probably start with 'notmuch-' I'd also mention that name starting with in-* -- my first thought would have been inconsistency, but that "namespace" naming is (even) more important. another thing what should be the parameters passed, and why. this change adds (just) message-id but no reasoning (nor documentation) there... other than these notes, the change looks reasonable to me, too :D > > d Tomi