From: Michal Nazarewicz <mina86@mina86.com>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: Re: Release checks v3
Date: Tue, 04 Sep 2012 17:41:46 +0200 [thread overview]
Message-ID: <xa1tzk55hk1x.fsf@mina86.com> (raw)
In-Reply-To: <1346770153-14947-1-git-send-email-tomi.ollila@iki.fi>
[-- Attachment #1: Type: text/plain, Size: 973 bytes --]
On Tue, Sep 04 2012, Tomi Ollila wrote:
> This if V3 of release-check.sh patches, displacing
>
> id:"1346491928-2356-1-git-send-email-tomi.ollila@iki.fi"
>
> Changes:
>
> Bash kept, mainly for pipefail -- and that possible future pipeline
> additions have more protection.
>
> Added set -o posix lessens drifts to more bashishms -- and somewhere was
> mentioned that posix mode provides a bit more robust pipefail...
>
> Changed that one short circuit & continues to if... elif... fi construct.
>
> Used *[^0-9.]*) for matching non-digit and non-dot characters; this
> was really nice one.
>
> One formatting change (added newline).
>
> Removed last 'exit 0'.
Looks good to me.
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
[-- Attachment #2.1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2.2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2012-09-04 15:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 14:49 Release checks v3 Tomi Ollila
2012-09-04 14:49 ` [PATCH v3 1/2] devel: add release-checks.sh Tomi Ollila
2012-09-04 14:49 ` [PATCH v3 2/2] {., man}/Makefile.local: edit/remove release-checks.sh related targets Tomi Ollila
2012-09-04 15:41 ` Michal Nazarewicz [this message]
2012-09-05 11:45 ` Release checks v3 David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xa1tzk55hk1x.fsf@mina86.com \
--to=mina86@mina86.com \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).