unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Michal Nazarewicz <mina86@mina86.com>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: ‘class Xapian::Database’ has no member named ‘close’
Date: Tue, 14 Aug 2012 14:26:13 +0200	[thread overview]
Message-ID: <xa1tk3x1psm2.fsf@mina86.com> (raw)
In-Reply-To: <87a9xx4yuj.fsf@maritornes.cs.unb.ca>

[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]

> Michal Nazarewicz <mina86@mina86.com> writes:
>> $ dpkg -l |grep xapian
>> ii  apt-xapian-index  0.25ubuntu2      maintenance tools for a Xapian index of Debi
>> ii  libxapian-dev     1.0.18-1         Development files for Xapian search engine l
>> ii  libxapian15       1.0.18-1         Search engine library

David Bremner <david@tethera.net> writes:
> This might be a bug with the install documentation; it could be we
> really need a later xapian to build.

Yeah, it seems that INSTALL claims “Notmuch will work best with Xapian
1.0.18 (or later) or Xapian 1.1.4 (or later)”, which doesn't seem to be
the case.

On top of that, configure does not seem to even check the version
number.

> From memory, maybe 1.0.20 has the "close" method. 1.0.18 is pretty
> old; Debian squeeze has 1.2.3, and that must be almost 3 years old
> now.

Is close() really required though?  The comment justifies it saying
that:

	Many Xapian objects hold references to the database, so merely
	deleting the database may not suffice to close it.  Thus, we
	explicitly close it here.

but wouldn't the database get closed when the last reference gets
deleted anyway?

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--

[-- Attachment #2.1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2.2: Type: application/pgp-signature, Size: 835 bytes --]

  reply	other threads:[~2012-08-14 12:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-07 15:23 ‘class Xapian::Database’ has no member named ‘close’ Michal Nazarewicz
2012-08-14  9:17 ` David Bremner
2012-08-14 12:26   ` Michal Nazarewicz [this message]
2012-08-14 12:57     ` Jani Nikula
2012-08-14 17:22       ` Justus Winter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xa1tk3x1psm2.fsf@mina86.com \
    --to=mina86@mina86.com \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).