notmuch-emacs: svg icon cannot be rendered by emacs-mac

notmuch-emacs: svg icon cannot be rendered by emacs-mac

[LdBeth]

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]


The svg icons included in notmuch-emacs cannot be correctly rendered
by emacs-mac (https://bitbucket.org/mituharu/emacs-mac/src/master/),
which uses OSX's builtin frameworks instead of imagemagick to render
images.

The empty SVG created by `svg-image' function from svg.el has XML
attribute `xmlns' like:

"<svg width=\"50\" height=\"50\" version=\"1.1\" xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\">
</svg>"

which is missing from SVG icons defined in `notmuch-tag.el'

Thanks.

--
LDB


[-- Attachment #2: 截圖 2022-01-12 上午6.29.56.png --]
[-- Type: image/png, Size: 104519 bytes --]

[-- Attachment #3: Type: text/plain, Size: 1 bytes --]



[-- Attachment #4: 截圖 2022-01-12 上午6.40.21.png --]
[-- Type: image/png, Size: 345611 bytes --]

[-- Attachment #5: Type: text/plain, Size: 0 bytes --]

Re: notmuch-emacs: svg icon cannot be rendered by emacs-mac

[Tomi Ollila]

On Wed, Jan 12 2022, LdBeth wrote:

> The svg icons included in notmuch-emacs cannot be correctly rendered
> by emacs-mac (https://bitbucket.org/mituharu/emacs-mac/src/master/),
>
> The empty SVG created by `svg-image' function from svg.el has XML
> attribute `xmlns' like:
>
> "<svg width=\"50\" height=\"50\" version=\"1.1\" xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\">
> </svg>"
>
> which is missing from SVG icons defined in `notmuch-tag.el'

First, IMO mac svg renderer is lame not to be lenient enough 
(and dont follow Postel's Law...) to just render those... anyway

... probably just adding xmlns=\"http://www.w3.org/2000/svg\"
to the svg strings in notmuch-tag.el could work. 
This just needs someone to test it. Adding the code is pretty easy :D,
but either someone w/ mac should do and test the change -- and send
patch email -- or definite information what works so someone else(tm)
(or her friend!) can do the change w/o testing :D

This is very easy to test, in started emacs first load notmuch, then
load notmuch-tag.el into new buffer, edit suitable svg functions, then
M-x eval-buffer (all these before executing any notmuch functions as
the first evaluation of those functions may be the only time those 
are called...

Tomi

PS: the new notmuch-logo.svg has the above xmlns in its implementation so
that should work :D

>
> Thanks.
>
> --
> LDB