unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Olly Betts <olly@survex.com>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH 2/5] Add quotes around id:"message-id" queries.
Date: Fri, 2 Jul 2010 04:41:43 +0000 (UTC)	[thread overview]
Message-ID: <slrni2qrg7.chp.olly@msgid.survex.com> (raw)
In-Reply-To: 1278000507-22290-3-git-send-email-dmitry.kurochkin@gmail.com

On 2010-07-01, Dmitry Kurochkin wrote:
> -  (concat "id:" (notmuch-show-get-prop :id props)))
> +  (concat "id:\"" (notmuch-show-get-prop :id props) "\""))

This is probably a good idea (the ".." example is arguably a Xapian bug so
that should be fixed soon, but you find all sorts of junk in message-ids.

However, the quoting feature this relies on was added in Xapian 1.0.18 (and
1.1.4), and with older versions this will break for *all* message-ids (even
those which currently work).

Also, if you're going to quote the message-id, you should escaping any "
characters in the message-id (by doubling them).

Cheers,
    Olly

  reply	other threads:[~2010-07-02  4:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-01 16:08 [PATCH 0/5] some fixes for emacs client Dmitry Kurochkin
2010-07-01 16:08 ` [PATCH 1/5] Use notmuch-show-get-message-id in notmuch-show-get-bodypart-content Dmitry Kurochkin
2010-07-01 16:08 ` [PATCH 2/5] Add quotes around id:"message-id" queries Dmitry Kurochkin
2010-07-02  4:41   ` Olly Betts [this message]
2010-07-02 13:04     ` Dmitry Kurochkin
2010-07-05  7:33       ` Olly Betts
2010-07-01 16:08 ` [PATCH 3/5] Use message-field-value instead of message-fetch-field Dmitry Kurochkin
2010-07-01 16:08 ` [PATCH 4/5] Add notmuch-hook. Called when notmuch is started, before notmuch-hello buffer is created Dmitry Kurochkin
2010-07-01 16:08 ` [PATCH 5/5] Add notmuch-hello-hook. Called every time notmuch-hello buffer is updated Dmitry Kurochkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=slrni2qrg7.chp.olly@msgid.survex.com \
    --to=olly@survex.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).