From: Martin Jambor <mjambor@suse.cz>
To: Michael J Gruber <michaeljgruber+grubix+git@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] Install notmuch-git during make install
Date: Fri, 23 Aug 2024 17:46:30 +0200 [thread overview]
Message-ID: <ri65xrr6y3t.fsf@virgil.suse.cz> (raw)
In-Reply-To: <CAA19uiSu0MZEfePoCMQbVY+A0eUY4_sR0RM874EW=aw5F3Q-wQ@mail.gmail.com>
Hi,
On Thu, Aug 22 2024, Michael J Gruber wrote:
> Am Do., 22. Aug. 2024 um 14:37 Uhr schrieb Martin Jambor <mjambor@suse.cz>:
>>
>> Hi,
>>
>> I have noticed that notmuch-git was not being copied to an appropriate
>> destination during make install. This patch adds that.
>>
>> ---
>> Makefile.local | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Makefile.local b/Makefile.local
>> index 7699c208..34e8b882 100644
>> --- a/Makefile.local
>> +++ b/Makefile.local
>> @@ -278,6 +278,7 @@ notmuch-shared: $(notmuch_client_modules) lib/$(LINKER_NAME)
>> install: all install-man install-info
>> mkdir -p "$(DESTDIR)$(prefix)/bin/"
>> install notmuch-shared "$(DESTDIR)$(prefix)/bin/notmuch"
>> + install notmuch-git "$(DESTDIR)$(prefix)/bin/notmuch-git"
>
> notmuch-git(1) mentions nmbug, so we'd want to install that as well, don't we?
I don't know. I have never even contemplated using it but it looks
much more like an internal tool to me.
However, after a discussion about notmuch-git on the IRC I learned that
there may be plans to change it, so perhaps even my patch should be
postponed until after that. I really don't know.
Martin
next prev parent reply other threads:[~2024-08-23 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 12:27 [PATCH] Install notmuch-git during make install Martin Jambor
2024-08-22 13:03 ` Michael J Gruber
2024-08-23 15:42 ` David Bremner
2024-08-23 15:46 ` Martin Jambor [this message]
2024-08-24 16:17 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ri65xrr6y3t.fsf@virgil.suse.cz \
--to=mjambor@suse.cz \
--cc=michaeljgruber+grubix+git@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).