From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 0A9406DE0A73 for ; Wed, 19 Oct 2016 15:33:41 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.487 X-Spam-Level: X-Spam-Status: No, score=-0.487 tagged_above=-999 required=5 tests=[AWL=-0.165, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.211, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9VrWmWbD3XUM for ; Wed, 19 Oct 2016 15:33:40 -0700 (PDT) Received: from mail-pf0-f179.google.com (mail-pf0-f179.google.com [209.85.192.179]) by arlo.cworth.org (Postfix) with ESMTPS id 3A6FC6DE0962 for ; Wed, 19 Oct 2016 15:33:40 -0700 (PDT) Received: by mail-pf0-f179.google.com with SMTP id s8so23164159pfj.2 for ; Wed, 19 Oct 2016 15:33:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=2ozHQhBuksFeDyrPrE3HPXEuj7mQ4q0hHvL3itCmXAA=; b=LydUX+p+WH1cSdAEY9oPV4zc5qqsIn6RUZNq4nsYSvTOcsclzBlrTCRLBGd8SwQGXV JftS/723s34rrC9F+0THgELZrqos6wB6rJ4KD9pEP6GtsV0Xv6495epYiQY4IuGWVkp8 oZBFNZ+lnDwx8rDwqJG2ICrm3jRyCJEn6XlXx8HyZA3SIp/so83dGGW3nxnYcBeMC2v7 VS97Zdme3y9B7TVo58shWWm4pBnskMCdLqTDMOEmebS6mkl6ai6/fKU9uHceB6Gqd/qH r5voB4Gd7gtdHzXAMSX6nZKOjc3nOShFewBtlXnKfTyrVzXP+8MHW4mVNm1tOrCXPusN LCqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=2ozHQhBuksFeDyrPrE3HPXEuj7mQ4q0hHvL3itCmXAA=; b=TCO8sDKQsVRa2PnFP8KGoXRLZYkhVJ8xyyXlsZajQPWJUs/7xF++/4GJmC3UEkkUWb JaxnrAjiYlffZ/8ExSILUe/B4VVejucj4L8VM7G/v7F2zrKgr2NwdKPon+8ZgzcovLH9 fyBzQ1T3um6jceMOq800cbJUKVlJzfMMsb2VyNd2BWwvpw1rI+FwlSU/QqayOSi9OHK4 h8Hbszkb3VOvX1ZCsIyq/6EoJbAXU8XEjTGoI006SzMDLbgfdhsbTibldV7DB4QojEvN Z0Wk402UzR2s1ktBb9sv/Z9Ud+kW3qrSmA/caqmB2KUJytB0g2tMR2aGwkEjjl7JbqBF gseA== X-Gm-Message-State: AA6/9Rlolao9UdMfkWz7xKAJAupRK5uuOP5dXZalBBXyk9n1x9i7Ys6VRNt0yjSRgho5MG3p X-Received: by 10.98.144.219 with SMTP id q88mr15427046pfk.116.1476916419672; Wed, 19 Oct 2016 15:33:39 -0700 (PDT) Received: from marmstrong-linux.kir.corp.google.com ([2620:0:1008:11:e964:81b:22b:5b97]) by smtp.gmail.com with ESMTPSA id s64sm66169549pfk.81.2016.10.19.15.33.38 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 19 Oct 2016 15:33:39 -0700 (PDT) From: Matt Armstrong To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: fix notmuch-search-line-faces defcustom In-Reply-To: <1476524448-20606-1-git-send-email-markwalters1009@gmail.com> References: <1476524448-20606-1-git-send-email-markwalters1009@gmail.com> Date: Wed, 19 Oct 2016 15:33:38 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2016 22:33:41 -0000 Mark Walters writes: > In commit 2a7b11b064233afc4feead876fa396e3c18a6b91 the default value > for notmuch-search-line-faces was changed so that it didn't match the > specification in the corresponding defcustom. This meant that it was > difficult for the user to customize this variable as they got a type > mismatch error. Mark, thanks for fixing the defcustom that I broke. :-) I have verified that it now works for me. This testing induced me to zero-out my notmuch face customizations, which reminded me that the defaults are bad in places for Emacs themes with dark backgrounds. I'll send a patch for that.