From: Radu Butoi <rbutoi@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH] emacs: split-window-sensibly in tree mode with open message
Date: Sat, 02 May 2020 20:11:09 -0400 [thread overview]
Message-ID: <prg8o8r5dgiq.fsf@butoi.nyc.corp.google.com> (raw)
Hello,
This uses the standard Emacs function `split-window-sensibly` to split a
window horizontally or vertically depending on space when opening a
message in tree view. By default, split-width-threshold is 160 columns
(and -height- is nil), so screens wider than 160 will be split
horizontally.
This is based on an older proposal [1] which manually did the
calculation of width. The main issues there were (1) lack of
configurability and (2) lack of testing. I don't have an answer for
testing, but this allows users to configure two thresholds using
built-in variables, an improvement.
Also, should I update the NEWS file? I see its latest changes are in
November and there's been user-visible changes since.
Thanks,
Radu
[1]: http://notmuch.198994.n3.nabble.com/emacs-Split-wide-window-vertically-for-tree-mode-message-pane-td4039070.html
The original patch email follows:
From 1ce4789b11007b46619faed7bf14f54686ca3538 Mon Sep 17 00:00:00 2001
From: Radu Butoi <rbutoi@gmail.com>
Subject: [PATCH] emacs: split-window-sensibly in tree mode with open message
When showing messages in tree-mode, this will split the window
horizontally or vertically depending on the
split-{width,height}-threshold.
---
emacs/notmuch-tree.el | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
index 254664c4..353700a1 100644
--- a/emacs/notmuch-tree.el
+++ b/emacs/notmuch-tree.el
@@ -524,8 +524,7 @@ NOT change the database."
;; We close and reopen the window to kill off un-needed buffers
;; this might cause flickering but seems ok.
(notmuch-tree-close-message-window)
- (setq notmuch-tree-message-window
- (split-window-vertically (/ (window-height) 4)))
+ (setq notmuch-tree-message-window (split-window-sensibly))
(with-selected-window notmuch-tree-message-window
;; Since we are only displaying one message do not indent.
(let ((notmuch-show-indent-messages-width 0)
--
2.26.2
next reply other threads:[~2020-05-03 0:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 0:11 Radu Butoi [this message]
2020-05-03 11:19 ` [PATCH] emacs: split-window-sensibly in tree mode with open message David Bremner
2020-05-09 19:14 ` Radu Butoi
2020-05-21 21:56 ` Daniel Kahn Gillmor
2020-05-22 5:03 ` Radu Butoi
2020-05-22 18:58 ` Mark Walters
2020-05-23 19:32 ` Daniel Kahn Gillmor
2020-05-26 18:48 ` Radu Butoi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=prg8o8r5dgiq.fsf@butoi.nyc.corp.google.com \
--to=rbutoi@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).