From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uCa3ABddx16SagAA0tVLHw (envelope-from ) for ; Fri, 22 May 2020 05:03:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id SDUxOBZdx14ffgAAB5/wlQ (envelope-from ) for ; Fri, 22 May 2020 05:03:18 +0000 Received: from arlo.cworth.org (arlo.cworth.org [50.126.95.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 55C5F94038D for ; Fri, 22 May 2020 05:03:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 52D836DE1378; Thu, 21 May 2020 22:03:12 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lrrD0bgQ63UZ; Thu, 21 May 2020 22:03:11 -0700 (PDT) Received: from arlo.cworth.org (localhost [IPv6:::1]) by arlo.cworth.org (Postfix) with ESMTP id 1FF906DE0F60; Thu, 21 May 2020 22:03:11 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 63ADB6DE0F60 for ; Thu, 21 May 2020 22:03:10 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZTHlJYrKV4VL for ; Thu, 21 May 2020 22:03:09 -0700 (PDT) Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by arlo.cworth.org (Postfix) with ESMTPS id 0F7E86DE0F46 for ; Thu, 21 May 2020 22:03:09 -0700 (PDT) Received: by mail-qk1-f194.google.com with SMTP id f13so9669851qkh.2 for ; Thu, 21 May 2020 22:03:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=n/KXcz8Z9EoGQj6BxxHYnfVKmJwSxx+k1UPXUUDVVHY=; b=ghzinFY4/Gd20xoFlmGenQ78DhdA4iVms8EK2r1NenudiWm3ziQXEHajglr7qRmEEf +C/JIaSCv5t4d863+kDvyUTkV6BE4u6Xa1sJymKvLCEFV4RifKa6Ht2u/YTeDtDHHJ25 Y0UWKWAPIjLo0AJw4e49GaN7sO4srFwMvY8BrLwkJ/ieu1onCma7cfKxYa1M1h819jvs hoFareI39cIfIOZZIWOx/+rsaxUlQDWjz6+MCeufARVE2f+eA9jeN62n1TGMyHdHkrCC OL1lo25srxmd5GvwClazfiRxZ+3biO1LfFFHfyU/YUOkpsIXQk/q4by6G5KkBioOtrjA lpMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=n/KXcz8Z9EoGQj6BxxHYnfVKmJwSxx+k1UPXUUDVVHY=; b=V+9Cf36VLheIrCrmjnoWJ1kTUwcXzH7wycGX9uzdSn+Q32E4kz4FI0YD5B8hI9NaOf uBUJLDXVkjJ2iWKmPk4/YWc7sHO9CwUTMLcTA48Tr9V2ruUyHhyI3DhSwGPYhmxctNyN HDVHFDiYbxj9gCB+iWDru+K8vhKpkyNmKTgs02dIf8dwp+kMrTcyaI9oiNhW62+/VXKk gK/c4MaVjoVtY5wXqZ6khlmsvmJ0GqtXrunLo0xOz65MvGuZavgN2yaDCmR1wZDnunvV 9K72v6DKUbY4y+BKwxqVt1knkCpMHPjl6+lmEuRm6KkjowbmzAQxmUplit7n86aGxlZh 8Olg== X-Gm-Message-State: AOAM530K+9YoLEJ8B+9er0bhzu/PHCrBI2HCikWy5b7G4OZ4fX7eFo1a ib1vIXTiAI9p1QwrcPV6HAo= X-Google-Smtp-Source: ABdhPJwmGsjqw11GoWVgZSY5YbVnjjWthdFYJ8C5T6YSVFilQvc8lAIVVrWIhth2c/fu0iwBuqF0Xw== X-Received: by 2002:a37:4e4e:: with SMTP id c75mr13418241qkb.143.1590123786957; Thu, 21 May 2020 22:03:06 -0700 (PDT) Received: from localhost (cpe-74-72-51-189.nyc.res.rr.com. [74.72.51.189]) by smtp.gmail.com with ESMTPSA id z65sm6422634qkc.91.2020.05.21.22.03.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2020 22:03:05 -0700 (PDT) From: Radu Butoi To: Daniel Kahn Gillmor , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: split-window-sensibly in tree mode with open message In-Reply-To: <87367tj6jl.fsf@fifthhorseman.net> References: <87367tj6jl.fsf@fifthhorseman.net> Date: Fri, 22 May 2020 01:03:05 -0400 Message-ID: MIME-Version: 1.0 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: notmuch-bounces@notmuchmail.org Sender: "notmuch" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=gmail.com header.s=20161025 header.b=ghzinFY4; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 50.126.95.6 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: 0.09 X-TUID: Z0N4dedLjPcU Daniel Kahn Gillmor writes: > I like this proposal, and the simplification that it gives to the > notmuch-emacs codebase. However, this thread is the first place i've > learned about split-window-sensibly, so i'm probably not eligible to > really judge the merits here. For some historical context, split-window-sensibly was introduced in 2009 [1] and the (split-window-vertically (/ (window-height) 4)) code in 2012 [2]. The two functions seem pretty interchangeable. > As far as testing goes, a test would be nice -- is this something you > could add to test/T460-emacs-tree.sh ? Testing UI/UX issues is always > pretty tough though, and it's not clear to me that we're actually > already testing the existing "(/ (window-height) 4)" business anyway. I did look at that file, and there is no tests for the current split functionality. All of the tests use the test-output function which outputs the contents of a buffer -- we need the whole frame. This might need to be done at a layer above Emacs and may complicate the test. I took a "screenshot" by copying my terminal contents with tmux, but I'm not sure how that would look like in a test. If I manually do the split on the test case [3], the fourth line does cut off some of the text since it goes beyond 160 columns, the default threshold. It is still viewable by pressing C-e, like anything too long. So I agree that testing would be nice but it seems to be an existing problem here. I'm not sure how, or if, other Emacs packages do character-perfect tests like these. -Radu [1]: git.savannah.gnu.org/cgit/emacs.git/commit/?id=8b10a2d19895041340296a703ba956c77541ec88 [2]: git.notmuchmail.org/git?p=notmuch;a=commit;h=3d92a257c8adbb36615bc61be9e668c8188006dc [3]: https://gist.githubusercontent.com/rbutoi/78c5b30fc5e64585bda18abbc5bf1fbf/raw/cba7df184f3cd534c92a6fb9bf39aa121c19ecd7/gistfile1.txt