[PATCH] emacs: `notmuch' should display the `notmuch-hello' interface

[PATCH] emacs: `notmuch' should display the `notmuch-hello' interface

[dme]

From: David Edmondson <dme@dme.org>

---
 emacs/notmuch-hello.el |    1 -
 emacs/notmuch-lib.el   |    5 +++++
 emacs/notmuch.el       |    7 +++----
 3 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index 30b3a5e..bd882b8 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -24,7 +24,6 @@
 (require 'cl)
 
 (require 'notmuch-lib)
-(require 'notmuch)
 (require 'notmuch-mua)
 
 (declare-function notmuch-search "notmuch" (query &optional oldest-first target-thread target-line continuation))
diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
index 47c74b9..b64aeab 100644
--- a/emacs/notmuch-lib.el
+++ b/emacs/notmuch-lib.el
@@ -33,6 +33,11 @@
   :type '(alist :key-type (string) :value-type (string))
   :group 'notmuch)
 
+(defcustom notmuch-search-oldest-first t
+  "Show the oldest mail first when searching."
+  :type 'boolean
+  :group 'notmuch)
+
 ;;
 
 (defun notmuch-version ()
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index eecff23..428ae6c 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -54,6 +54,7 @@
 (require 'notmuch-lib)
 (require 'notmuch-show)
 (require 'notmuch-mua)
+(require 'notmuch-hello)
 
 (defcustom notmuch-search-result-format
   `(("date" . "%s ")
@@ -221,8 +222,6 @@ For a mouse binding, return nil."
 (defvar notmuch-search-query-string)
 (defvar notmuch-search-target-thread)
 (defvar notmuch-search-target-line)
-(defvar notmuch-search-oldest-first t
-  "Show the oldest mail first in the search-mode")
 (defvar notmuch-search-continuation)
 
 (defvar notmuch-search-disjunctive-regexp      "\\<[oO][rR]\\>")
@@ -811,9 +810,9 @@ current search results AND that are tagged with the given tag."
 
 ;;;###autoload
 (defun notmuch ()
-  "Run notmuch to display all mail with tag of 'inbox'"
+  "Run notmuch and display saved searches, known tags, etc."
   (interactive)
-  (notmuch-search "tag:inbox" notmuch-search-oldest-first))
+  (notmuch-hello))
 
 (setq mail-user-agent 'notmuch-user-agent)
 
-- 
1.7.0

Re: [PATCH] emacs: `notmuch' should display the `notmuch-hello' interface

[Dirk Hohndel]

This is lacking a committ message...

On Mon, 26 Apr 2010 16:07:04 +0100, dme@dme.org wrote:
> From: David Edmondson <dme@dme.org>
> --- a/emacs/notmuch-lib.el
> +++ b/emacs/notmuch-lib.el
> @@ -33,6 +33,11 @@
>    :type '(alist :key-type (string) :value-type (string))
>    :group 'notmuch)
>  
> +(defcustom notmuch-search-oldest-first t
> +  "Show the oldest mail first when searching."
> +  :type 'boolean
> +  :group 'notmuch)
> +

And this doesn't seem related to the subject...

> @@ -221,8 +222,6 @@ For a mouse binding, return nil."
>  (defvar notmuch-search-query-string)
>  (defvar notmuch-search-target-thread)
>  (defvar notmuch-search-target-line)
> -(defvar notmuch-search-oldest-first t
> -  "Show the oldest mail first in the search-mode")
>  (defvar notmuch-search-continuation)
>  
>  (defvar notmuch-search-disjunctive-regexp      "\\<[oO][rR]\\>")

ditto...

... just saying...

/D

-- 
Dirk Hohndel
Intel Open Source Technology Center

Re: [PATCH] emacs: `notmuch' should display the `notmuch-hello' interface

[David Edmondson]

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

On Mon, 26 Apr 2010 09:11:07 -0700, Dirk Hohndel <hohndel@infradead.org> wrote:
> This is lacking a committ message...

I wasn't sure what else to say.

> On Mon, 26 Apr 2010 16:07:04 +0100, dme@dme.org wrote:
> > From: David Edmondson <dme@dme.org>
> > --- a/emacs/notmuch-lib.el
> > +++ b/emacs/notmuch-lib.el
> > @@ -33,6 +33,11 @@
> >    :type '(alist :key-type (string) :value-type (string))
> >    :group 'notmuch)
> >  
> > +(defcustom notmuch-search-oldest-first t
> > +  "Show the oldest mail first when searching."
> > +  :type 'boolean
> > +  :group 'notmuch)
> > +
> 
> And this doesn't seem related to the subject...
> 
> > @@ -221,8 +222,6 @@ For a mouse binding, return nil."
> >  (defvar notmuch-search-query-string)
> >  (defvar notmuch-search-target-thread)
> >  (defvar notmuch-search-target-line)
> > -(defvar notmuch-search-oldest-first t
> > -  "Show the oldest mail first in the search-mode")
> >  (defvar notmuch-search-continuation)
> >  
> >  (defvar notmuch-search-disjunctive-regexp      "\\<[oO][rR]\\>")
> 
> ditto...

They are both due to re-arranging the relationship between notmuch.el
and notmuch-hello.el.

dme.
-- 
David Edmondson, http://dme.org

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] emacs: `notmuch' should display the `notmuch-hello' interface

[Dirk Hohndel]

On Mon, 26 Apr 2010 17:30:04 +0100, David Edmondson <dme@dme.org> wrote:
> On Mon, 26 Apr 2010 09:11:07 -0700, Dirk Hohndel <hohndel@infradead.org> wrote:
> > This is lacking a committ message...
> 
> I wasn't sure what else to say.
> 
> > 
> > And this doesn't seem related to the subject...
> 
> They are both due to re-arranging the relationship between notmuch.el
> and notmuch-hello.el.

Maybe the commit message could have mentioned how this was impacted by
the change in relationship. At least to me it wasn't obvious at all

/D

-- 
Dirk Hohndel
Intel Open Source Technology Center

Re: [PATCH] emacs: `notmuch' should display the `notmuch-hello' interface

[Carl Worth]

[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]

On Mon, 26 Apr 2010 17:30:04 +0100, David Edmondson <dme@dme.org> wrote:
> On Mon, 26 Apr 2010 09:11:07 -0700, Dirk Hohndel <hohndel@infradead.org> wrote:
> > This is lacking a committ message...

Thanks for the review, Dirk! Much appreciated.

> I wasn't sure what else to say.

Here's what I came up with in my --amend of the commit message:

    emacs: `notmuch' should display the `notmuch-hello' interface
    
    Reviewed-by: Carl Worth <cworth@cworth.org>
    
    The notmuch-hello functionality is now sufficiently useful that we
    want to make it the default view of notmuch for new users. This also
    effectively hides the "hello" name from the user, so we'll be free to
    change that in the implementation if necessary.
    
    This change also shuffles the requires between notmuch.el and
    notmuch-hello.el. This fixes things so that our documented (require
    'notmuch) is sufficient for getting the notmuch-hello functionality.
    
    Finally, the shuffling caused the notmuch-search-oldest-first variable
    from one file to the other. While doing that, give this variable the
    defcustom treatment for easier customization.

Pushed.

-Carl

-- 
carl.d.worth@intel.com

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]