unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] fix obvious cut and paste error
@ 2010-04-06 22:36 Dirk Hohndel
  2010-04-07  1:56 ` Carl Worth
  0 siblings, 1 reply; 2+ messages in thread
From: Dirk Hohndel @ 2010-04-06 22:36 UTC (permalink / raw)
  To: notmuch


the wrong variable is checked for success of an allocation

Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
---
 lib/thread.cc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/thread.cc b/lib/thread.cc
index 1c8b39d..48c070e 100644
--- a/lib/thread.cc
+++ b/lib/thread.cc
@@ -236,7 +236,7 @@ _notmuch_thread_create (void *ctx,
 	return NULL;
 
     matched_query = notmuch_query_create (notmuch, matched_query_string);
-    if (unlikely (thread_id_query == NULL))
+    if (unlikely (matched_query == NULL))
 	return NULL;
 
     thread = talloc (ctx, notmuch_thread_t);
-- 
1.6.6.1



-- 
Dirk Hohndel
Intel Open Source Technology Center

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] fix obvious cut and paste error
  2010-04-06 22:36 [PATCH] fix obvious cut and paste error Dirk Hohndel
@ 2010-04-07  1:56 ` Carl Worth
  0 siblings, 0 replies; 2+ messages in thread
From: Carl Worth @ 2010-04-07  1:56 UTC (permalink / raw)
  To: Dirk Hohndel, notmuch

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

On Tue, 06 Apr 2010 15:36:25 -0700, Dirk Hohndel <hohndel@infradead.org> wrote:
> -    if (unlikely (thread_id_query == NULL))
> +    if (unlikely (matched_query == NULL))

Good catch. This is pushed now.

-Carl

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-04-07  1:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-06 22:36 [PATCH] fix obvious cut and paste error Dirk Hohndel
2010-04-07  1:56 ` Carl Worth

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).