From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 2579C4196F3 for ; Sat, 24 Apr 2010 15:05:58 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -4.2 X-Spam-Level: X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jDCKQBOj9db6 for ; Sat, 24 Apr 2010 15:05:57 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by olra.theworths.org (Postfix) with ESMTP id 04FD3431FC1 for ; Sat, 24 Apr 2010 15:05:56 -0700 (PDT) Received: from localhost ([::1] helo=x200.gr8dns.org) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1O5nU4-0003nx-BS; Sat, 24 Apr 2010 22:05:56 +0000 Received: by x200.gr8dns.org (Postfix, from userid 500) id CA906CC5CA; Sat, 24 Apr 2010 15:05:55 -0700 (PDT) From: Dirk Hohndel To: Carl Worth , notmuch@notmuchmail.org Subject: Re: Wrapping up the 0.3 release In-Reply-To: <87aassh6d2.fsf@yoom.home.cworth.org> References: <87ljcchnfc.fsf@yoom.home.cworth.org> <87aassh6d2.fsf@yoom.home.cworth.org> User-Agent: Notmuch/0.2-197-ged00626 (http://notmuchmail.org) Emacs/23.1.1 (i386-redhat-linux-gnu) Date: Sat, 24 Apr 2010 15:05:55 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Apr 2010 22:05:58 -0000 On Sat, 24 Apr 2010 14:45:45 -0700, Carl Worth wrote: > > It doesn't for me with origin/master. Or let me double check... what do > > you think would be the correct order (as this is a matter of taste for > > some people)... > > The order in the reply buffer is fine. But with "m" I get the User-Agent > first which looks a bit strange. Yep, same here. > Dirk also mentioned in IRC that there's a regression with the signature > being mispositioned before the quoted text with a reply buffer. Now that > I've added a signature, I'm noticing this as well. Well - we don't seem to be adding the signature ourselves anymore... I still don't quite understand where and how we hand over to the existing message-mode functions - I why those decide to insert a signature at point. Here's a trivial patch that ALSO adds a signature at the end of the message buffer (where it belongs). But I haven't figured out how to get rid of the one above the reply... diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el index acb7dbf..493cd0e 100644 --- a/emacs/notmuch-mua.el +++ b/emacs/notmuch-mua.el @@ -63,6 +63,7 @@ ;; line and then the body. (with-temp-buffer (call-process notmuch-command nil t nil "reply" query-string) + (message-insert-signature) (goto-char (point-min)) (if (re-search-forward "^$" nil t) (save-excursion > > I think we should make this a "requirement" for patches to include a > > little NEWS blurb and either a test case or an explanation why there > > isn't a test case... > > I've asked for these, but I haven't been pushing hard on this. I will start playing the nagger > Review for some of these simple things would be much appreciated from > anybody on the list, (and would help ensure that patches are more likely > to be ready-to-go once I get them). So let's see more of things like > this from anyone on the list: > > Looks like a great feature---now it just needs a test case. > > I've tested this and it does just what I want. Here's a > follow-on patch that adds an item to the NEWS file for this. > > I can't common on the specific logic of the patch, but I did > notice some trailing whitespace. You'll want to clean that up > and resubmit so the patch won't be rejected. I can do all of those. /D -- Dirk Hohndel Intel Open Source Technology Center