unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Dirk Hohndel <hohndel@infradead.org>
To: David Edmondson <dme@dme.org>, notmuch <notmuch@notmuchmail.org>
Subject: Re: [PATCH] RFC: Add From guessing when forwarding email
Date: Mon, 26 Apr 2010 09:25:45 -0700	[thread overview]
Message-ID: <m31ve2kwom.fsf@x200.gr8dns.org> (raw)
In-Reply-To: <87och65w9q.fsf@ut.hh.sledj.net>

On Mon, 26 Apr 2010 11:43:45 +0100, David Edmondson <dme@dme.org> wrote:
> On Fri, 23 Apr 2010 15:52:15 -0700, Dirk Hohndel <hohndel@infradead.org> wrote:
> > Given how little elisp I know I'm quite interested in feedback
> > and better implementations
> 
> I think that:
> 
> (defun notmuch-show-forward-message ()
>   "Forward the current message."
>   (interactive)
>   (let ((user-mail-address
> 	 (shell-command-to-string (concat notmuch-command
> 					  "guess-from"
> 					  (notmuch-show-get-message-id)))))
>     (with-current-notmuch-show-message
>      (notmuch-mua-forward-message))))
> 
> is more idiomatic.

Thanks - I was sure that my lack of elisp foo was showing (even though I
was quite proud that I was able to get it to work at all).

I'll submit an updated patch for the 0.4 merge window.

/D

-- 
Dirk Hohndel
Intel Open Source Technology Center

  reply	other threads:[~2010-04-26 16:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-23 22:52 [PATCH] RFC: Add From guessing when forwarding email Dirk Hohndel
2010-04-26 10:43 ` David Edmondson
2010-04-26 16:25   ` Dirk Hohndel [this message]
2010-04-26 23:27 ` Carl Worth
2010-04-27  1:51   ` Dirk Hohndel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m31ve2kwom.fsf@x200.gr8dns.org \
    --to=hohndel@infradead.org \
    --cc=dme@dme.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).