From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 2897D431FB6
	for <notmuch@notmuchmail.org>; Wed, 14 Aug 2013 10:04:23 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id L7nBQsy8c0bl for <notmuch@notmuchmail.org>;
	Wed, 14 Aug 2013 10:04:16 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id AC2F0431FAF
	for <notmuch@notmuchmail.org>; Wed, 14 Aug 2013 10:04:16 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
	by guru.guru-group.fi (Postfix) with ESMTP id B9B56100051;
	Wed, 14 Aug 2013 20:04:10 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/6] Clean up reply's encoding story
In-Reply-To: <1376332839-22825-1-git-send-email-amdragon@mit.edu>
References: <1376332839-22825-1-git-send-email-amdragon@mit.edu>
User-Agent: Notmuch/0.16+3~g340c058 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Wed, 14 Aug 2013 20:04:10 +0300
Message-ID: <m2zjskjjat.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Aug 2013 17:04:23 -0000

On Mon, Aug 12 2013, Austin Clements <amdragon@MIT.EDU> wrote:

> Jeff Stedfast's email about gmime-filter-headers.c possibly being
> unnecessary with GMime 2.6 (quoted in id:87bo56viyo.fsf@nikula.org)
> sent me on a wild goose chase that led to this patch series.  It
> turned out that we *did* need gmime-filter-headers for what we were
> doing in the reply text format, but what we were doing made no sense.
> Patches 1 through 4 are simply the documentation and tests that I left
> in my wake and are harmless to push.  Patch 6 is my conclusion that
> how we were handling header encoding in the text reply format made no
> sense.  Patch 5 is a step toward patch 6, but makes sense on its own
> even if we decide against patch 6.

The whole series Looks Good To Me (sans known hiccups). I tested the patch 6
affecting 'default' output of notmuch reply bot not json or sexp output
(which I found surprising as so much code was removed). All the explations
in id:1376332839-22825-7-git-send-email-amdragon@mit.edu makes good sense
(but fix also 'tmeplate').

A slighly related note: ^M:s ^J:s (among other chars) don't get encoded
into =?utf-8?b?...?= ...

... also interestingly if U+202E (LEFT-TO-RIGHT OVERRIDE) is in (at least
From) header it disappears from `notmuch reply` default format. In json
and sexp format it disappears in 'reply-headers' but exists in 'headers'.
emacs client seems to use reply-headers as none of the header text lines
in buffer is  rendered RTL.


Tomi

>
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch