From: Tomi Ollila <tomi.ollila@iki.fi>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/6] Clean up reply's encoding story
Date: Wed, 14 Aug 2013 20:04:10 +0300 [thread overview]
Message-ID: <m2zjskjjat.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1376332839-22825-1-git-send-email-amdragon@mit.edu>
On Mon, Aug 12 2013, Austin Clements <amdragon@MIT.EDU> wrote:
> Jeff Stedfast's email about gmime-filter-headers.c possibly being
> unnecessary with GMime 2.6 (quoted in id:87bo56viyo.fsf@nikula.org)
> sent me on a wild goose chase that led to this patch series. It
> turned out that we *did* need gmime-filter-headers for what we were
> doing in the reply text format, but what we were doing made no sense.
> Patches 1 through 4 are simply the documentation and tests that I left
> in my wake and are harmless to push. Patch 6 is my conclusion that
> how we were handling header encoding in the text reply format made no
> sense. Patch 5 is a step toward patch 6, but makes sense on its own
> even if we decide against patch 6.
The whole series Looks Good To Me (sans known hiccups). I tested the patch 6
affecting 'default' output of notmuch reply bot not json or sexp output
(which I found surprising as so much code was removed). All the explations
in id:1376332839-22825-7-git-send-email-amdragon@mit.edu makes good sense
(but fix also 'tmeplate').
A slighly related note: ^M:s ^J:s (among other chars) don't get encoded
into =?utf-8?b?...?= ...
... also interestingly if U+202E (LEFT-TO-RIGHT OVERRIDE) is in (at least
From) header it disappears from `notmuch reply` default format. In json
and sexp format it disappears in 'reply-headers' but exists in 'headers'.
emacs client seems to use reply-headers as none of the header text lines
in buffer is rendered RTL.
Tomi
>
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2013-08-14 17:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 18:40 [PATCH 0/6] Clean up reply's encoding story Austin Clements
2013-08-12 18:40 ` [PATCH 1/6] lib: Correct out-of-date doc comment Austin Clements
2013-08-12 18:40 ` [PATCH 2/6] lib: Document which strings are returned in UTF-8 Austin Clements
2013-08-12 18:40 ` [PATCH 3/6] reply: Document the reason for g_mime_filter_headers Austin Clements
2013-08-15 8:40 ` David Bremner
2013-08-12 18:40 ` [PATCH 4/6] reply: Test replying to messages with RFC 2047-encoded headers Austin Clements
2013-08-13 16:13 ` Austin Clements
2013-08-12 18:40 ` [PATCH 5/6] reply: Remove extraneous space from generated References Austin Clements
2013-08-12 18:40 ` [PATCH 6/6] reply: Use RFC 2822/MIME wholly for text format template Austin Clements
2013-08-12 20:01 ` Austin Clements
2013-08-14 17:04 ` Tomi Ollila [this message]
2013-08-14 17:20 ` [PATCH 0/6] Clean up reply's encoding story Austin Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2zjskjjat.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).