[PATCH] go: add binding for notmuch_message_get_date

[PATCH] go: add binding for notmuch_message_get_date

[Trevor Jim]

---
 bindings/go/src/notmuch/notmuch.go | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/bindings/go/src/notmuch/notmuch.go b/bindings/go/src/notmuch/notmuch.go
index b9230ad..f5fd54c 100644
--- a/bindings/go/src/notmuch/notmuch.go
+++ b/bindings/go/src/notmuch/notmuch.go
@@ -801,7 +801,13 @@ func (self *Message) SetFlag(flag Flag, value bool) {
 	C.notmuch_message_set_flag(self.message, C.notmuch_message_flag_t(flag), v)
 }
 
-// TODO: wrap notmuch_message_get_date
+func  (self *Message) GetDate() int64 {
+	if self.message == nil {
+		return -1
+	}
+	timestamp := C.notmuch_message_get_date(self.message)
+	return int64(timestamp)
+}
 
 /* Get the value of the specified header from 'message'.
  *
-- 
2.2.2

Re: [PATCH] go: add binding for notmuch_message_get_date

[Tomi Ollila]

On Mon, Mar 02 2015, Trevor Jim <tjim@mac.com> wrote:

> ---
>  bindings/go/src/notmuch/notmuch.go | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/bindings/go/src/notmuch/notmuch.go b/bindings/go/src/notmuch/notmuch.go
> index b9230ad..f5fd54c 100644
> --- a/bindings/go/src/notmuch/notmuch.go
> +++ b/bindings/go/src/notmuch/notmuch.go
> @@ -801,7 +801,13 @@ func (self *Message) SetFlag(flag Flag, value bool) {
>  	C.notmuch_message_set_flag(self.message, C.notmuch_message_flag_t(flag), v)
>  }
>  
> -// TODO: wrap notmuch_message_get_date
> +func  (self *Message) GetDate() int64 {
> +	if self.message == nil {
> +		return -1

-1 is 1969-dec-31 23:59:59 UTC

Should we care -- and e.g. return status in separate return value ?

Tomi

> +	}
> +	timestamp := C.notmuch_message_get_date(self.message)
> +	return int64(timestamp)
> +}
>  
>  /* Get the value of the specified header from 'message'.
>   *
> -- 
> 2.2.2

Re: [PATCH] go: add binding for notmuch_message_get_date

[David Bremner]

Tomi Ollila <tomi.ollila@iki.fi> writes:

>On Mon, Mar 02 2015, Trevor Jim <tjim@mac.com> wrote:
>>  
>> -// TODO: wrap notmuch_message_get_date
>> +func  (self *Message) GetDate() int64 {
>> +	if self.message == nil {
>> +		return -1
>
> -1 is 1969-dec-31 23:59:59 UTC
>
> Should we care -- and e.g. return status in separate return value ?

Given the current troubles with the main library API and missing status
values, I'd say in the long run we'll be happier with a real status
return. OTOH, I don't much about go.

d

Re: [PATCH] go: add binding for notmuch_message_get_date

[Trevor Jim]

> Given the current troubles with the main library API and missing status
> values, I'd say in the long run we'll be happier with a real status
> return. OTOH, I don't much about go.

I'm not sure what the "current troubles" are (happy to hear more), but
the way I've handled the nil case is in keeping with the way it's
handled in the other function bindings for go.  Adding an error return
to all relevant functions seems like a big change that should be handled
separately, yes?

In defense of the current strategy, any caller can check for the nil
case before calling.

-T

Re: [PATCH] go: add binding for notmuch_message_get_date

[David Bremner]

Trevor Jim <tjim@mac.com> writes:


> I'm not sure what the "current troubles" are (happy to hear more), but
> the way I've handled the nil case is in keeping with the way it's
> handled in the other function bindings for go.  Adding an error return
> to all relevant functions seems like a big change that should be handled
> separately, yes?

It seems like at least some functions [1] already use multiple return values
to return a status value.  There is also already a STATUS_NULL_POINTER
defined.  

[1]: from notmuch.go

func NewDatabase(path string) (*Database, Status) {
func OpenDatabase(path string, mode DatabaseMode) (*Database, Status) {
func (self *Database) Close() Status {
func (self *Database) GetDirectory(path string) (*Directory, Status) {
func (self *Database) AddMessage(fname string) (*Message, Status) {
func (self *Database) RemoveMessage(fname string) Status {
func (self *Database) FindMessage(message_id string) (*Message, Status) {
func (self *Message) AddTag(tag string) Status {
func (self *Message) RemoveTag(tag string) Status {
func (self *Message) RemoveAllTags() Status {
func (self *Message) Freeze() Status {
func (self *Message) Thaw() Status {

Re: [PATCH] go: add binding for notmuch_message_get_date

[Trevor Jim]

> -1 is 1969-dec-31 23:59:59 UTC
>
> Should we care -- and e.g. return status in separate return value ?

BTW, I notice that when a message has no Date: field, notmuch reports its
timestamp as 0 without reporting an error :-)

-Trevor