From: David Edmondson <dme@dme.org>
To: William Casarin <jb55@jb55.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 1/8] emacs/tree: return true if a thread was found in next-thread
Date: Thu, 28 Nov 2019 16:24:25 +0000 [thread overview]
Message-ID: <m2zhgg3r5y.fsf@dme.org> (raw)
In-Reply-To: <20191128161401.28844-2-jb55@jb55.com>
On Thursday, 2019-11-28 at 08:13:54 -08, William Casarin wrote:
> This will allow us to pop back to parent buffers when there are no
> more threads to jump to.
>
> Signed-off-by: William Casarin <jb55@jb55.com>
> ---
> emacs/notmuch-tree.el | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
> index c00315e8..4bc05160 100644
> --- a/emacs/notmuch-tree.el
> +++ b/emacs/notmuch-tree.el
> @@ -620,10 +620,14 @@ message will be \"unarchived\", i.e. the tag changes in
> (notmuch-tree-thread-top))
>
> (defun notmuch-tree-next-thread ()
> + "Get the next thread in the current tree. Returns t if a thread was
> +found or nil if not."
> (interactive)
> (forward-line 1)
> - (while (not (or (notmuch-tree-get-prop :first) (eobp)))
> - (forward-line 1)))
> + (let (end)
> + (while (not (or (notmuch-tree-get-prop :first) (setq end (eobp))))
> + (forward-line 1))
> + (not end)))
Does using the variable add much value here? It makes the code look more
strange and removing it would add the cost of just one more call to
`eobp'.
>
> (defun notmuch-tree-thread-mapcar (function)
> "Iterate through all messages in the current thread
> --
> 2.23.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
dme.
--
But uh oh, I love her because, she moves in her own way.
next prev parent reply other threads:[~2019-11-28 16:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 16:13 [PATCH v2 0/8] Port notmuch-show's x/X bindings to notmuch-tree William Casarin
2019-11-28 16:13 ` [PATCH v2 1/8] emacs/tree: return true if a thread was found in next-thread William Casarin
2019-11-28 16:24 ` David Edmondson [this message]
2019-12-04 19:14 ` William Casarin
2019-11-28 16:13 ` [PATCH v2 2/8] emacs/tree: add notmuch-tree-goto-matching-message William Casarin
2019-11-28 16:25 ` David Edmondson
2019-12-04 19:15 ` William Casarin
2019-11-28 16:13 ` [PATCH v2 3/8] emacs/tree: add notmuch-tree-matching-message William Casarin
2019-11-28 16:13 ` [PATCH v2 4/8] emacs/tree: add kill-both prefix argument to notmuch-tree-quit William Casarin
2019-11-28 16:13 ` [PATCH v2 5/8] emacs/tree: add notmuch-tree-archive-message-than-next-or-exit William Casarin
2019-11-28 16:13 ` [PATCH v2 6/8] emacs/tree: add notmuch-tree-archive-thread-then-exit William Casarin
2019-11-28 16:14 ` [PATCH v2 7/8] emacs/tree: add x/X bindings William Casarin
2019-11-28 16:14 ` [PATCH v2 8/8] emacs: bind M-RET to notmuch-tree-from-search-thread William Casarin
2019-12-04 17:01 ` [PATCH v2 0/8] Port notmuch-show's x/X bindings to notmuch-tree Teemu Likonen
2019-12-04 19:18 ` William Casarin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2zhgg3r5y.fsf@dme.org \
--to=dme@dme.org \
--cc=jb55@jb55.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).