From: Xavier Maillard <xavier@maillard.im>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] Ignore encrypted parts when indexing.
Date: Wed, 28 Dec 2011 13:40:42 +0100 [thread overview]
Message-ID: <m2y5twc1it.fsf@kcals.intra.maillard.im> (raw)
In-Reply-To: <1325005901-21374-1-git-send-email-jrollins@finestructure.net>
Hi Jameson,
On Tue, 27 Dec 2011 09:11:41 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> It appears to be an oversight that encrypted parts were indexed
> previously. The terms generated from encrypted parts are meaningless
> and do nothing but add bloat to the database. It is not worth
> indexing the encrypted content, just as it's not worth indexing the
> signatures in signed parts.
+1 for this.
But,
> + if (GMIME_IS_MULTIPART_ENCRYPTED (multipart)) {
> + /* Don't index encrypted parts. */
> + continue
This needs a semicolon, doesn't it ?
/Xavier
next prev parent reply other threads:[~2011-12-28 12:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-27 17:11 [PATCH] Ignore encrypted parts when indexing Jameson Graef Rollins
2011-12-28 3:31 ` Austin Clements
2011-12-28 12:40 ` Xavier Maillard [this message]
2011-12-28 20:14 ` [PATCH v2] " Jameson Graef Rollins
2011-12-28 20:36 ` Austin Clements
2011-12-28 21:53 ` Tomi Ollila
2011-12-29 22:07 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y5twc1it.fsf@kcals.intra.maillard.im \
--to=xavier@maillard.im \
--cc=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
--cc=xma@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).