From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [Patch v2 1/4] nmbug: use dump --format=batch-tag
Date: Thu, 21 Feb 2013 14:22:42 +0200 [thread overview]
Message-ID: <m2y5ehvotp.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <87k3q151fx.fsf@zancas.localnet>
On Thu, Feb 21 2013, David Bremner <david@tethera.net> wrote:
> Tomi Ollila <tomi.ollila@iki.fi> writes:
>
>>
>> This patch series looks good to me (as far as I can understand, I did
>> not find the "silly bug" in your previous patch...)
>>
>
> Compare :
>
> + print $notmuch $A_action.$TAGPREFIX.$pair->{tag}, " -- ",
> + 'id:'.$pair->{id};
>
> vs.
>
> + print $notmuch $D_action.$TAGPREFIX.$pair->{tag},
> + 'id:'.$pair->{id};
Ah, ok :)
> I obviously did not test that version very well.
IIRC that has happened to some other people, too ;(
>> Instead of mentioning that "calls are _not_ passed to shell" here,
>> that could be briefly mentioned just before system() calls in the
>> script -- and that definitely should not be 'At the moment' feature.
>
> Sure, the "At the moment" is meant to modify "relies". In the next
> patch, we stop relying on this feature of Perl.
Well, one have to expect the execution to happen one way or another
(and arrange quoting accordingly); for example:
$ echo; perl -e 'exec q/echo "foobar"/'
foobar
vs.
$ echo; perl -e 'exec qw/echo "foobar"/'
"foobar"
first gave exec one arg, 'echo "foobar"' and due to "":s perl used sh
to execute it, second gave exec list [ 'echo', '"foobar"' ] and therefore
echo got foobar with quotes as a command line argument.
Anyone interested for more information, see 'perldoc -f exec'.
>> the system() function in perl(1) never pass execution through the
>> shell in case the args are list more than one arg:
>
> right. that's what I meant by "is a documented feature of perl's system
> function"
>
> So I think we mean to say the same thing here; but I could I add a
> comment in this patch (to delete it in the next). Or maybe reword that
> commit message somehow.
Yes, the message is the same, just that there should not be need for that..
> d
Tomi
next prev parent reply other threads:[~2013-02-21 12:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 22:24 Update for nmbug, round 2 david
2013-02-20 22:24 ` [Patch v2 1/4] nmbug: use dump --format=batch-tag david
2013-02-21 8:30 ` Tomi Ollila
2013-02-21 11:52 ` David Bremner
2013-02-21 12:22 ` Tomi Ollila [this message]
2013-02-20 22:24 ` [Patch v2 2/4] nmbug: use 'notmuch tag --batch' david
2013-02-20 22:24 ` [Patch v2 3/4] nmbug: replace hard-coded magic hash with git-hash-object david
2013-02-20 22:24 ` [Patch v2 4/4] nmbug: allow empty prefix david
2013-02-27 8:53 ` Update for nmbug, round 2 Tomi Ollila
2013-02-27 11:59 ` David Bremner
2013-03-02 14:51 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y5ehvotp.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).