unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH v3 0/6] Make Emacs search use sexp format
Date: Sat, 01 Jun 2013 09:50:40 +0300	[thread overview]
Message-ID: <m2y5auz5mn.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1370047208-12785-1-git-send-email-amdragon@mit.edu>

On Sat, Jun 01 2013, Austin Clements <amdragon@MIT.EDU> wrote:

> This is v3 of id:1369934016-22308-1-git-send-email-amdragon@mit.edu.
> This tweaks the shell invocation as suggested by Tomi and fixes two
> comment typos pointed out by Mark.  It also adds a NEWS patch.  I'm
> going to go ahead and mark this ready because of Tomi's and Mark's
> reviews of v2.

+1

Tomi


>
> The diff from v2 follows
>
> diff --git a/NEWS b/NEWS
> index 80abd97..2a4bde6 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -66,6 +66,17 @@ notmuch-vim, but of course that is their decision.
>  Emacs Interface
>  ---------------
>  
> +Better handling of errors in search buffers
> +
> +  Instead of interleaving errors in search result buffers, search mode
> +  now reports errors in the minibuffer.
> +
> +Faster search results
> +
> +  Communication between search mode and the notmuch CLI is now more
> +  efficient because it uses the CLI's S-expression support.  As a
> +  result, search mode should now fill search buffers faster.
> +
>  No Emacs 22 support
>  
>    The Emacs 22 support added late 2010 was sufficient only for a short
> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
> index 180f63d..a206808 100644
> --- a/emacs/notmuch-lib.el
> +++ b/emacs/notmuch-lib.el
> @@ -497,8 +497,8 @@ status."
>  	 (command (or (executable-find notmuch-command)
>  		      (error "command not found: %s" notmuch-command)))
>  	 (proc (apply #'start-process name buffer
> -		      "sh" "-c"
> -		      "ERR=\"$1\"; shift; exec \"$0\" \"$@\" 2>\"$ERR\""
> +		      "/bin/sh" "-c"
> +		      "exec 2>\"$1\"; shift; exec \"$0\" \"$@\""
>  		      command err-file args)))
>      (process-put proc 'err-file err-file)
>      (process-put proc 'sub-sentinel sentinel)
> @@ -533,8 +533,8 @@ status."
>  	    (when warnings
>  	      (notmuch-logged-error (car warnings) (cdr warnings)))))
>        (error
> -       ;; Emacs behaves strangely if error an error escapes from a
> -       ;; sentinel, so turns errors into messages.
> +       ;; Emacs behaves strangely if an error escapes from a sentinel,
> +       ;; so turn errors into messages.
>         (message "%s" (error-message-string err))))
>      (ignore-errors (delete-file err-file))))
>  
>
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

  parent reply	other threads:[~2013-06-01  6:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-01  0:40 [PATCH v3 0/6] Make Emacs search use sexp format Austin Clements
2013-06-01  0:40 ` [PATCH v3 1/6] test: Remove extraneous Emacs error handling test Austin Clements
2013-06-01  0:40 ` [PATCH v3 2/6] emacs: Utilities to manage asynchronous notmuch processes Austin Clements
2013-06-01  0:40 ` [PATCH v3 3/6] emacs: Use async process helper for search Austin Clements
2013-06-01  0:40 ` [PATCH v3 4/6] emacs: Streaming S-expression parser Austin Clements
2013-06-01  0:40 ` [PATCH v3 5/6] emacs: Use streaming S-expr parser for search Austin Clements
2013-06-01  0:40 ` [PATCH v3 6/6] News for S-expression support in Emacs search mode Austin Clements
2013-06-01  6:50 ` Tomi Ollila [this message]
2013-06-01 12:07 ` [PATCH v3 0/6] Make Emacs search use sexp format David Bremner
2013-06-02 15:51   ` Jameson Graef Rollins
2013-06-04  5:33     ` Austin Clements
2013-06-05 15:21       ` Jameson Graef Rollins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2y5auz5mn.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).