From: Tomi Ollila <tomi.ollila@iki.fi>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [RFC] lib: add support for date:<query>..! to mean date:<query>..<query>
Date: Sat, 18 Apr 2015 11:07:10 +0300 [thread overview]
Message-ID: <m2y4lplv0x.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1425732959-2282-1-git-send-email-jani@nikula.org>
On Sat, Mar 07 2015, Jani Nikula <jani@nikula.org> wrote:
> Up to debate:
>
> 1) Is something like this useful at all as an intermediate step before
> we can have support for date:<query>? (This can be done with a future
> version of Xapian, or with a custom query query parser.)
>
> 2) If yes, are there better alternatives to "!" as the end point? (Or
> should the special case be the start point?) Also "@" and "same" have
> been suggested. Examples: date:yesterday..! date:today..@
> date:@..monday date:january..same.
I'd rather see a temporary ugly hack in implementation (to expand
date:<date> to date:<date>..<date>) than permanent interface feature.
But this looks simple enough... and I'd go just with this implementation
(i.e. <date>..!)
Tomi
> diff --git a/lib/parse-time-vrp.cc b/lib/parse-time-vrp.cc
> index 33f07db3410e..03804cf50fa8 100644
> --- a/lib/parse-time-vrp.cc
> +++ b/lib/parse-time-vrp.cc
> @@ -31,6 +31,7 @@ Xapian::valueno
> ParseTimeValueRangeProcessor::operator() (std::string &begin, std::string &end)
> {
> time_t t, now;
> + std::string b;
>
> /* Require date: prefix in start of the range... */
> if (STRNCMP_LITERAL (begin.c_str (), PREFIX))
> @@ -38,6 +39,7 @@ ParseTimeValueRangeProcessor::operator() (std::string &begin, std::string &end)
>
> /* ...and remove it. */
> begin.erase (0, sizeof (PREFIX) - 1);
> + b = begin;
>
> /* Use the same 'now' for begin and end. */
> if (time (&now) == (time_t) -1)
> @@ -51,6 +53,9 @@ ParseTimeValueRangeProcessor::operator() (std::string &begin, std::string &end)
> }
>
> if (!end.empty ()) {
> + if (end == "!" && ! b.empty ())
> + end = b;
> +
> if (parse_time_string (end.c_str (), &t, &now, PARSE_TIME_ROUND_UP_INCLUSIVE))
> return Xapian::BAD_VALUENO;
>
next prev parent reply other threads:[~2015-04-18 8:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-07 12:55 [RFC] lib: add support for date:<query>..! to mean date:<query>..<query> Jani Nikula
2015-04-17 18:57 ` Mark Walters
2015-04-18 0:12 ` Suvayu Ali
2015-04-19 8:39 ` Gaute Hope
2015-04-19 11:54 ` David Bremner
2015-04-18 8:07 ` Tomi Ollila [this message]
2015-06-08 14:57 ` David Bremner
2015-08-15 11:25 ` [PATCH] lib: add support for date:<expr>..! to mean date:<expr>..<expr> Jani Nikula
2015-09-26 1:03 ` David Bremner
2015-09-26 13:55 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y4lplv0x.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).