From: David Edmondson <dme@dme.org>
To: Mark Walters <markwalters1009@gmail.com>,
David Bremner <david@tethera.net>,
Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
David Mazieres expires 2016-07-03 PDT
<mazieres-297ctmng4fhr6h6ad8yffa64yi@temporary-address.scs.stanford.edu>,
notmuch@notmuchmail.org
Subject: Re: Breaking a really long thread
Date: Mon, 11 Apr 2016 08:39:27 +0100 [thread overview]
Message-ID: <m2y48kmw5s.fsf@dme.org> (raw)
In-Reply-To: <87y48kipdw.fsf@qmul.ac.uk>
On Mon, Apr 11 2016, Mark Walters wrote:
> On Mon, 11 Apr 2016, David Bremner <david@tethera.net> wrote:
>> Mark Walters <markwalters1009@gmail.com> writes:
>>
>>> I think we already have this, except it is called
>>> notmuch-mua-hidden-headers. It defaults to '("^User-Agent:").
>>>
>>> I think it would be reasonable to add In-Reply-To to this list.
>>>
>>> However, if I read the code correctly, currently we are changing
>>> message-hidden-headers globally which doesn't feel the right thing to
>>> do. Probably we should do something more like you suggest, and do the
>>> overriding just in notmuch-message-mode.
>>>
>>
>> Summarizing, I see 3 related changes here
>>
>> - fixing the code to let-bind message-hidden-headers instead of globally
>> modify it
>
> I have a patch doing this, but there is one problem that i don't see how
> to solve neatly. At the moment we set hidden-headers to the union of
> message-hidden-headers and notmuch-mua-hidden-headers. This means that
> if the user wants to show a header that is normally one of
> message-hidden-headers they have to set message-hidden-headers (ie they
> can't just change notmuch-mua-hidden headers).
>
> If we want it that people can show such a header just by changing a
> notmuch variable then I don't see how to do it neatly without breaking
> some existing setups.
>
> Any suggestions?
My inclination is to say "if you want to change the headers that are
hidden in message mode, change `message-hidden-headers'" and don't
bother with any notmuch specific settings.
That, of course, leads me to wonder why I ever added
`notmuch-mua-hidden-headers' in the first place...
> Best wishes
>
> Mark
>
>>
>> - adding in-reply-to notmuch-mua
>>
>> - providing a keybinding to toggle visibility of hidden headers that
>> works better than the current use of widen
>>
>> d
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2016-04-11 7:39 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-26 17:57 v2 of libconfig, date:foo, and named query patches David Bremner
2016-03-26 17:57 ` [Patch v2 01/13] configure: autodetect xapian-1.3 David Bremner
2016-04-01 9:09 ` Tomi Ollila
2016-04-01 23:29 ` David Bremner
2016-03-26 17:57 ` [Patch v2 02/13] configure: detect Xapian:FieldProcessor David Bremner
2016-03-26 17:57 ` [Patch v2 03/13] lib: optionally support single argument date: queries David Bremner
2016-03-26 17:57 ` [Patch v2 04/13] lib/cli: add library API / CLI for compile time options David Bremner
2016-04-27 17:47 ` Tomi Ollila
2016-04-30 11:53 ` David Bremner
2016-05-01 17:48 ` Tomi Ollila
2016-03-26 17:57 ` [Patch v2 05/13] configure: check directly for xapian compaction API David Bremner
2016-03-26 17:57 ` [Patch v2 06/13] lib: provide config API David Bremner
2016-03-26 17:57 ` [Patch v2 07/13] lib: config list iterators David Bremner
2016-03-26 17:57 ` [Patch v2 08/13] CLI: add print_status_database David Bremner
2016-03-27 20:25 ` [PATCH] nmbug: ignore # comments David Bremner
2016-03-27 20:38 ` W. Trevor King
2016-03-28 7:14 ` Tomi Ollila
2016-03-28 12:33 ` David Bremner
2016-03-26 17:57 ` [Patch v2 09/13] CLI: add optional config data to dump output David Bremner
2016-03-26 18:13 ` David Bremner
2016-03-26 17:57 ` [Patch v2 10/13] CLI: optionally restore config data David Bremner
2016-03-26 17:57 ` [Patch v2 11/13] CLI: add notmuch-config support for named queries David Bremner
2016-03-26 17:57 ` [Patch v2 12/13] lib: make a global constant for query parser flags David Bremner
2016-03-26 17:57 ` [Patch v2 13/13] lib: add support for named queries David Bremner
2016-04-01 23:57 ` Breaking a really long thread David Mazieres
2016-04-02 12:41 ` David Bremner
2016-04-02 13:56 ` David Mazieres
2016-04-04 11:07 ` Eric
2016-04-04 13:00 ` Mark Walters
2016-04-04 15:38 ` Eric
2016-04-05 5:28 ` David Mazieres
2016-04-09 11:20 ` Daniel Kahn Gillmor
2016-04-09 18:55 ` David Bremner
2016-04-09 22:40 ` Mark Walters
2016-04-11 2:05 ` David Bremner
2016-04-11 7:19 ` Mark Walters
2016-04-11 7:39 ` David Edmondson [this message]
2016-04-11 9:57 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y48kmw5s.fsf@dme.org \
--to=dme@dme.org \
--cc=david@tethera.net \
--cc=dkg@fifthhorseman.net \
--cc=markwalters1009@gmail.com \
--cc=mazieres-297ctmng4fhr6h6ad8yffa64yi@temporary-address.scs.stanford.edu \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).