From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 6FA4A6DE1065
 for <notmuch@notmuchmail.org>; Sun,  5 May 2019 03:22:10 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0.44
X-Spam-Level: 
X-Spam-Status: No, score=0.44 tagged_above=-999 required=5 tests=[AWL=-0.212, 
 SPF_NEUTRAL=0.652] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id M0seECm8l1He for <notmuch@notmuchmail.org>;
 Sun,  5 May 2019 03:22:09 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
 by arlo.cworth.org (Postfix) with ESMTP id F27C36DE0F9A
 for <notmuch@notmuchmail.org>; Sun,  5 May 2019 03:22:08 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
 by guru.guru-group.fi (Postfix) with ESMTP id 4237F1000E3;
 Sun,  5 May 2019 13:22:06 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: "Rollins\, Jameson" <jrollins@caltech.edu>,
 Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 1/3] tests: remove some redundant pre-cleanup of the
 corpus MAIL_DIR
In-Reply-To: <20190504205738.21504-2-jrollins@caltech.edu>
References: <20190504205738.21504-1-jrollins@caltech.edu>
 <20190504205738.21504-2-jrollins@caltech.edu>
User-Agent: Notmuch/0.28.3+84~g41389bb (https://notmuchmail.org) Emacs/25.2.1
 (x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
 !)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Sun, 05 May 2019 13:22:06 +0300
Message-ID: <m2y33lw69d.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 05 May 2019 10:22:10 -0000

On Sat, May 04 2019, Jameson Rollins wrote:

This change LGTM, marked trivial, removed needs-review

> From: Jameson Graef Rollins <jrollins@finestructure.net>
>
> add_email_corpus itself does an rm -rf $MAIL_DIR, so these are not necessary.
> ---
>  test/T100-search-by-folder.sh | 1 -
>  test/T650-regexp-query.sh     | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/test/T100-search-by-folder.sh b/test/T100-search-by-folder.sh
> index a090f3d2..409cfdcc 100755
> --- a/test/T100-search-by-folder.sh
> +++ b/test/T100-search-by-folder.sh
> @@ -56,7 +56,6 @@ output=$(notmuch search folder:duplicate/bad/olds | notmuch_search_sanitize)
>  test_expect_equal "$output" "thread:XXX   2001-01-05 [1/1] Notmuch Test Suite; Bears (inbox unread)"
>  
>  # folder: and path: searches with full corpus
> -rm -rf $MAIL_DIR
>  add_email_corpus
>  
>  # add some more dupes
> diff --git a/test/T650-regexp-query.sh b/test/T650-regexp-query.sh
> index 92334ba0..43af3b47 100755
> --- a/test/T650-regexp-query.sh
> +++ b/test/T650-regexp-query.sh
> @@ -47,7 +47,6 @@ output=$(notmuch search 'path:/^bad$/' | notmuch_search_sanitize)
>  test_expect_equal "$output" "thread:XXX   2001-01-05 [1/1] Notmuch Test Suite; To the bone (inbox unread)"
>  
>  # Use "standard" corpus from here on.
> -rm -rf $MAIL_DIR
>  add_email_corpus
>  
>  notmuch search --output=messages from:cworth > cworth.msg-ids
> -- 
> 2.20.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch