From: Tomi Ollila <tomi.ollila@iki.fi>
To: "Rollins\, Jameson" <jrollins@caltech.edu>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 1/3] tests: remove some redundant pre-cleanup of the corpus MAIL_DIR
Date: Sun, 05 May 2019 13:22:06 +0300 [thread overview]
Message-ID: <m2y33lw69d.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20190504205738.21504-2-jrollins@caltech.edu>
On Sat, May 04 2019, Jameson Rollins wrote:
This change LGTM, marked trivial, removed needs-review
> From: Jameson Graef Rollins <jrollins@finestructure.net>
>
> add_email_corpus itself does an rm -rf $MAIL_DIR, so these are not necessary.
> ---
> test/T100-search-by-folder.sh | 1 -
> test/T650-regexp-query.sh | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/test/T100-search-by-folder.sh b/test/T100-search-by-folder.sh
> index a090f3d2..409cfdcc 100755
> --- a/test/T100-search-by-folder.sh
> +++ b/test/T100-search-by-folder.sh
> @@ -56,7 +56,6 @@ output=$(notmuch search folder:duplicate/bad/olds | notmuch_search_sanitize)
> test_expect_equal "$output" "thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; Bears (inbox unread)"
>
> # folder: and path: searches with full corpus
> -rm -rf $MAIL_DIR
> add_email_corpus
>
> # add some more dupes
> diff --git a/test/T650-regexp-query.sh b/test/T650-regexp-query.sh
> index 92334ba0..43af3b47 100755
> --- a/test/T650-regexp-query.sh
> +++ b/test/T650-regexp-query.sh
> @@ -47,7 +47,6 @@ output=$(notmuch search 'path:/^bad$/' | notmuch_search_sanitize)
> test_expect_equal "$output" "thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; To the bone (inbox unread)"
>
> # Use "standard" corpus from here on.
> -rm -rf $MAIL_DIR
> add_email_corpus
>
> notmuch search --output=messages from:cworth > cworth.msg-ids
> --
> 2.20.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2019-05-05 10:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 20:57 parallelize test suite Rollins, Jameson
2019-05-04 20:57 ` [PATCH 1/3] tests: remove some redundant pre-cleanup of the corpus MAIL_DIR Rollins, Jameson
2019-05-04 20:57 ` [PATCH 2/3] tests: remove entangling corpus index optimization Rollins, Jameson
2019-05-04 20:57 ` [PATCH 3/3] tests: run all tests in parallel, if available Rollins, Jameson
2019-05-06 4:44 ` [PATCH] tests: environment variable to specify that tests should be serialized Rollins, Jameson
2019-05-06 10:32 ` [PATCH] test: add configurable port to smtp-dummy David Bremner
2019-05-06 19:39 ` Tomi Ollila
2019-05-06 20:55 ` Daniel Kahn Gillmor
2019-05-07 10:20 ` [PATCH] test: let the OS choose a port for smtp-dummy David Bremner
2019-05-07 12:38 ` Daniel Kahn Gillmor
2019-05-08 15:59 ` Tomi Ollila
2019-05-10 10:16 ` David Bremner
2019-05-06 19:15 ` [PATCH] tests: environment variable to specify that tests should be serialized Tomi Ollila
2019-05-06 20:58 ` Daniel Kahn Gillmor
2019-05-05 10:22 ` Tomi Ollila [this message]
2019-05-04 21:33 ` parallelize test suite Rollins, Jameson
2019-05-04 21:39 ` Daniel Kahn Gillmor
2019-05-04 22:53 ` David Bremner
2019-05-05 15:22 ` Daniel Kahn Gillmor
2019-05-05 16:44 ` Tomi Ollila
2019-05-06 21:39 ` Daniel Kahn Gillmor
2019-05-07 10:26 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y33lw69d.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=jrollins@caltech.edu \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).