From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 7DAF36DE1413 for ; Mon, 20 May 2019 10:11:34 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.434 X-Spam-Level: X-Spam-Status: No, score=0.434 tagged_above=-999 required=5 tests=[AWL=-0.218, SPF_NEUTRAL=0.652] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3WA9f4GU6Yty for ; Mon, 20 May 2019 10:11:33 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by arlo.cworth.org (Postfix) with ESMTP id E5C6F6DE13F9 for ; Mon, 20 May 2019 10:11:32 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 517951000D0; Mon, 20 May 2019 20:11:28 +0300 (EEST) From: Tomi Ollila To: Leo Vivier , notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] emacs: Move notmuch-search-interactive-region to notmuch-lib as notmuch-interactive-region In-Reply-To: <87ef4tcnid.fsf@hidden> References: <87ef4tcnid.fsf@hidden> User-Agent: Notmuch/0.28.3+84~g41389bb (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 May 2019 17:11:34 -0000 On Mon, May 20 2019, Leo Vivier wrote: > Hello, > > With the patch now in master, the documentation for Emacs (=E2=80=98Tips = and > Tricks for using Notmuch with Emacs=E2=80=99) needs to be updated: > https://notmuchmail.org/emacstips/#index5h2 > > =E2=80=98notmuch-search-interactive-region=E2=80=99 is mentioned in the s= econd block of > Elisp. > > Also, could we mark the old function as obsolete? Some of my commands > broke after pulling the changes, and that=E2=80=99s what led me to the do= c in > the first place. > > I=E2=80=99ve attached a quick patch for marking the old command as obsole= te. I > don't think the `emacstips' doc is in the repo, so I couldn't fix it. It is wiki -- look around the web page to see how to update. > > Best, > > --=20 > Leo Vivier > From 5481c2fe61d9e776d15166bc46f8dfc6221bf975 Mon Sep 17 00:00:00 2001 > From: Leo Vivier > Date: Mon, 20 May 2019 14:21:13 +0200 > Subject: [PATCH] emacs: make old function obsolete > > `notmuch-search-interactive-region' was moved to notmuch-lib.el in > f3cba19f882471a396a6b6175a709ccd1f6f34a0 and renamed to > `notmuch-interactive-region' without making the old function > obsolete, thereby breaking user-commands which made use of it. > > This patch marks the function as obsolete and makes it an alias for s/patch/commit/ -- it is no longer patch when applied! it may be possible that db could amend this... Tomi > the new function. > --- > emacs/notmuch-lib.el | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el > index 7fc342a5..96a1da90 100644 > --- a/emacs/notmuch-lib.el > +++ b/emacs/notmuch-lib.el > @@ -1017,6 +1017,11 @@ region if the region is active, or both `point' ot= herwise." > (list (region-beginning) (region-end)) > (list (point) (point)))) >=20=20 > +(define-obsolete-function-alias > + 'notmuch-search-interactive-region > + 'notmuch-interactive-region > + "notmuch 0.28.1") > + > (provide 'notmuch-lib) >=20=20 > ;; Local Variables: > --=20 > 2.21.0 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch