From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id ONJ2LilLsF6hKQAA0tVLHw (envelope-from ) for ; Mon, 04 May 2020 17:04:41 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id AAsBAzRLsF6+GQAA1q6Kng (envelope-from ) for ; Mon, 04 May 2020 17:04:52 +0000 Received: from arlo.cworth.org (arlo.cworth.org [50.126.95.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 89125944859 for ; Mon, 4 May 2020 14:16:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 641306DE0FB1; Mon, 4 May 2020 07:16:48 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7TJbgxPxUT-c; Mon, 4 May 2020 07:16:46 -0700 (PDT) Received: from arlo.cworth.org (localhost [IPv6:::1]) by arlo.cworth.org (Postfix) with ESMTP id 9C5F86DE0F86; Mon, 4 May 2020 07:16:45 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 485186DE0F86 for ; Mon, 4 May 2020 07:16:44 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k3vq9gZRjczX for ; Mon, 4 May 2020 07:16:42 -0700 (PDT) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [212.16.98.55]) by arlo.cworth.org (Postfix) with ESMTPS id ADC246DE0F07 for ; Mon, 4 May 2020 07:16:40 -0700 (PDT) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 79F9F1B000A0; Mon, 4 May 2020 17:16:34 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1588601794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q4zbOlGA709jxdKmNenTydnpoiD86sGJeXR4YWMxJRs=; b=VWUhspR4Vlwc6TUH57X7eRX1qIqMEKqFs655/6UQvDp7udqlx8iNGvZJbthTaD6QJ9xzsP Xe/TX3AhrTxgXRvPe5KVI7xeY7NmCcwzXrh/nYDnebPP9TlccVvwoVKyKODMarWZwhcI2R bhfCg4vcF0b6J1igyEg+kvyVVdmKsYgy4aFqc4T8MrFPriVIBGiVBriKisCJ5uERuo8YJc hxhNzGd7uqsD9aGn51/IPZJ/6oS0LEkuVfZ9l34u5BRHCm2L7hXx9mTykVcizc2oRBMMQT LVnY7gwQ9dXHz2sFgacYrR+tyzKgh+07ddtPtc0nWSmc1KB0RqPdF1bzGOQv2w== From: Tomi Ollila To: David Bremner , David Bremner , Franz Fellner , notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] test: known broken test for reindex tag preservation In-Reply-To: <20200504140024.1617656-1-david@tethera.net> References: <87h7wvg6oq.fsf@tethera.net> <20200504140024.1617656-1-david@tethera.net> User-Agent: Notmuch/0.28.3+84~g41389bb (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1588601794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q4zbOlGA709jxdKmNenTydnpoiD86sGJeXR4YWMxJRs=; b=BIIhhXggUTafFQZdC69U1UWaIpfmyG8rSSYtEHYZ2E5NgGUPHuRsxOx2l5VpV/ajLcgrNL Kj4FNGIvanEEc8losYkOW8M8IePLJDr5CqIwJBpXeM9uWugKKBbPFLmVFbFIsLfxoEDHQy qZqMble4j51MufuI/gejwvdOLf4WVKJEf400Oeajtyiea6TmpXLsl2Q6IHLwko/VW4ii7c v0rTW9nnW6XuYCzfvunKRb4rLVMW/Q5t5n1AaVYKCK8RqlcwAVH+LmCu6CVJQcDySLW5MJ pvMS0SM46HdE6IjAzDgWYs3uR8hlEM48HLI9TqCSwwLAheaL1jmMhmi52yEZZA== ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1588601794; a=rsa-sha256; cv=none; b=qlnFxncK/UJyEf6SxUtBWfwJYUFZRc4mMdYIgDE/ry6KlShJ9u2ZpcVMg7Gqq7E3u1A7KE Kutgwkvd+unr1PkGhSc+9Sx9doql3HoYbLWPOyYKOP8UbVrkpUYHT22hZKkiiMMGk16Qux polHsbj+GhPYFbm7hvy/JdagZ2FoflaKmVwLXtfqhHaMHoiFEmVlIWmkszh+M7ThO/FXgq SSDO3YUSIan72kSWfpUrdNAsRkN393BfeF8KbRh7WHTl/e3wv56I36IW8v2dB/KFP5vwHw B+fIDGdf7S7kAsPA8R1RmpyLxQW1TiA6BwcltH4VUzfFDHd/fMUFmqzNGCnOkQ== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: notmuch-bounces@notmuchmail.org Sender: "notmuch" X-Scanner: scn0 X-Spam-Score: 3.49 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=iki.fi header.s=lahtoruutu header.b=VWUhspR4; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 50.126.95.6 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Scan-Result: default: False [3.49 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.46580450012762]; FORGED_SENDER_MAILLIST(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:c]; IP_REPUTATION_HAM(0.00)[asn: 27017(-0.18), country: US(-0.00), ip: 50.126.95.6(-0.47)]; DWL_DNSWL_FAIL(0.00)[50.126.95.6:server fail]; R_DKIM_REJECT(1.00)[iki.fi:s=lahtoruutu]; ARC_REJECT(2.00)[signature check failed: fail, {[1] = sig:iki.fi:reject}]; MX_GOOD(-0.50)[cached: notmuchmail.org]; DKIM_TRACE(0.00)[iki.fi:-]; MAILLIST(-0.20)[mailman]; FREEMAIL_TO(0.00)[tethera.net,gmail.com,notmuchmail.org]; RCVD_IN_DNSWL_FAIL(0.00)[50.126.95.6:server fail]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:27017, ipnet:50.126.64.0/18, country:US]; FROM_NEQ_ENVFROM(0.00)[tomi.ollila@iki.fi,notmuch-bounces@notmuchmail.org]; URIBL_BLOCKED(0.00)[notmuchmail.org:email]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[notmuch@notmuchmail.org]; HAS_LIST_UNSUB(-0.01)[]; DMARC_NA(0.00)[iki.fi]; RCVD_COUNT_SEVEN(0.00)[8]; SUSPICIOUS_RECIPS(1.50)[] X-TUID: wlu9DtOLoDdm On Mon, May 04 2020, David Bremner wrote: > In id:1588595993-ner-8.651@TPL520 Franz Fellner reported that tags > starting with 'attachment' are removed by 'notmuch reindex'. This is > probably related to the use of STRNCMP_LITERAL in Haa, I looked this briefly but failed to see it is STRNCMP_LITERAL, not STRCMP_LITERAL (the latter could be optimized strcmp using memcmp w/ constant len) Series LGTM (I'm trying to look away that 'we' passive ;) Tomi > _notmuch_message_remove_indexed_terms. > --- > test/T700-reindex.sh | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/test/T700-reindex.sh b/test/T700-reindex.sh > index 9e795896..7b7e52de 100755 > --- a/test/T700-reindex.sh > +++ b/test/T700-reindex.sh > @@ -33,6 +33,15 @@ notmuch reindex '*' > notmuch dump > OUTPUT > test_expect_equal_file initial-dump OUTPUT > > +test_begin_subtest 'reindex preserves tags with special prefixes' > +test_subtest_known_broken > +notmuch tag +attachment2 +encrypted2 +signed2 '*' > +notmuch dump > EXPECTED > +notmuch reindex '*' > +notmuch dump > OUTPUT > +notmuch tag -attachment2 -encrypted2 -signed2 '*' > +test_expect_equal_file EXPECTED OUTPUT > + > test_begin_subtest 'reindex moves a message between threads' > notmuch search --output=threads id:87iqd9rn3l.fsf@vertex.dottedmag > EXPECTED > # re-parent > -- > 2.26.2 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch